From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v3 2/2] ALSA: usb-audio: update clock valid
	control
Date: Sat, 24 Mar 2018 09:51:59 +0100
Message-ID: <s5hh8p597ps.wl-tiwai@suse.de>
References: <20180324022524.227748-1-achant@google.com>
 <20180324022524.227748-3-achant@google.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id F3071266E91
 for <alsa-devel@alsa-project.org>; Sat, 24 Mar 2018 09:51:59 +0100 (CET)
In-Reply-To: <20180324022524.227748-3-achant@google.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Andrew Chant <achant@google.com>
Cc: alsa-devel@alsa-project.org, Ruslan Bilovol <ruslan.bilovol@gmail.com>, Benson Leung <bleung@google.com>
List-Id: alsa-devel@alsa-project.org

On Sat, 24 Mar 2018 03:25:24 +0100,
Andrew Chant wrote:
> 
> Make the "clock valid" control a global control instead of a mixer
> so that it doesn't appear in mixer applications.
> 
> Additionally, remove the check for writeability prohibited by spec, and
> Use common code to read the control value.
> 
> Tested with a UAC2 Audio device that presents a clock validity
> control.  The control still shows up in /proc usbmixer but not
> in alsamixer.
> 
> Signed-off-by: Andrew Chant <achant@google.com>

Applied now, thanks.


Takashi