From: Takashi Iwai Subject: Re: [PATCH] ALSA: line6: constify snd_kcontrol_new structures Date: Wed, 12 Apr 2017 15:35:58 +0200 Message-ID: References: <1492002647-11016-1-git-send-email-bhumirks@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <1492002647-11016-1-git-send-email-bhumirks@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Bhumika Goyal Cc: alsa-devel@alsa-project.org, julia.lawall@lip6.fr, perex@perex.cz, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Wed, 12 Apr 2017 15:10:47 +0200, Bhumika Goyal wrote: > > Declare snd_kcontrol_new strcutures as const as they are only passed as > an argument to the function snd_ctl_new1. This argument is of type const, > so snd_kcontrol_new structures having this property can be made const too. > Done using Coccinelle: > > @r disable optional_qualifier@ > identifier x; > position p; > @@ > static struct snd_kcontrol_new x@p={...}; > > @ok@ > identifier r.x; > position p; > @@ > snd_ctl_new1(&x@p,...) > > @bad@ > position p != {r.p,ok.p}; > identifier r.x; > @@ > x@p > > @depends on !bad disable optional_qualifier@ > identifier r.x; > @@ > +const > struct snd_kcontrol_new x; > > Signed-off-by: Bhumika Goyal Applied, thanks. Takashi