From: Takashi Iwai Subject: Re: [PATCH] ALSA: x86: hdmi: fix returnvar.cocci warnings Date: Wed, 25 Jan 2017 22:08:28 +0100 Message-ID: References: Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Julia Lawall Cc: alsa-devel@alsa-project.org, intel-gfx@lists.freedesktop.org, broonie@kernel.org, rakesh.a.ughreja@intel.com, kbuild-all@01.org List-Id: alsa-devel@alsa-project.org T24gVHVlLCAyNCBKYW4gMjAxNyAxNzowNzo0OCArMDEwMCwKSnVsaWEgTGF3YWxsIHdyb3RlOgo+ IAo+IFJlbW92ZSB1bm5lZWRlZCB2YXJpYWJsZSB1c2VkIHRvIHN0b3JlIHJldHVybiB2YWx1ZS4K PiAKPiBHZW5lcmF0ZWQgYnk6IHNjcmlwdHMvY29jY2luZWxsZS9taXNjL3JldHVybnZhci5jb2Nj aQo+IAo+IENDOiBKZXJvbWUgQW5hbmQgPGplcm9tZS5hbmFuZEBpbnRlbC5jb20+Cj4gU2lnbmVk LW9mZi1ieTogSnVsaWEgTGF3YWxsIDxqdWxpYS5sYXdhbGxAbGlwNi5mcj4KPiBTaWduZWQtb2Zm LWJ5OiBGZW5nZ3VhbmcgV3UgPGZlbmdndWFuZy53dUBpbnRlbC5jb20+Cj4gLS0tCj4gCj4gSW4t UmVwbHktVG86IDwyMDE3MDEyNDIyNTc1My45MDQ1LTUtamVyb21lLmFuYW5kQGludGVsLmNvbT4K PiB1cmw6Cj4gaHR0cHM6Ly9naXRodWIuY29tLzBkYXktY2kvbGludXgvY29tbWl0cy9KZXJvbWUt QW5hbmQvQWRkLXN1cHBvcnQtZm9yLUxlZ2FjeQo+IC1IRE1JLWF1ZGlvLWRyaXZlcnMvMjAxNzAx MjQtMjEzNTQ3Cj4gCj4gVGhpcyBpcyBwcm9iYWJseSBub3QgdGhlIHJpZ2h0IHBhdGNoLiAgSXQg c2kganVzdCB3aGF0IHRoZSBydWxlIGdlbmVyYXRlcy4KPiBJbnN0ZWFkLCBJIGd1ZXNzIHRoYXQg cmV0dmFsIHNob3VsZCBiZSB1cGRhdGVkIGluIHNvbWUgd2F5PwoKWWVhaCwgaXQgbG9va3MgYSBi aXQgc3VzcGljaW91cywgYnV0IGl0IGNhbiBiZSBmaXhlZCBsYXRlci4KU28gSSBhcHBsaWVkIHlv dXIgY2xlYW51cCBub3cuCgoKdGhhbmtzLAoKVGFrYXNoaQoKPiAKPiAgaW50ZWxfaGRtaV9hdWRp b19pZi5jIHwgICAyMSArKysrKysrKystLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDkg aW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCj4gCj4gLS0tIGEvc291bmQveDg2L2ludGVs X2hkbWlfYXVkaW9faWYuYwo+ICsrKyBiL3NvdW5kL3g4Ni9pbnRlbF9oZG1pX2F1ZGlvX2lmLmMK PiBAQCAtMjM5LDcgKzIzOSw2IEBAIHN0YXRpYyBpbmxpbmUgaW50IGhhZF9jaGtfaW50cm1pc3Mo c3RydWMKPiAKPiAgaW50IGhhZF9wcm9jZXNzX2J1ZmZlcl9kb25lKHN0cnVjdCBzbmRfaW50ZWxo YWQgKmludGVsaGFkZGF0YSkKPiAgewo+IC0JaW50IHJldHZhbCA9IDA7Cj4gIAl1MzIgbGVuID0g MTsKPiAgCWVudW0gaW50ZWxfaGFkX2F1ZF9idWZfdHlwZSBidWZfaWQ7Cj4gIAllbnVtIGludGVs X2hhZF9hdWRfYnVmX3R5cGUgYnVmZl9kb25lOwo+IEBAIC0yNTgsNyArMjU3LDcgQEAgaW50IGhh ZF9wcm9jZXNzX2J1ZmZlcl9kb25lKHN0cnVjdCBzbmRfaQo+ICAJaWYgKGludGVsaGFkZGF0YS0+ ZHJ2X3N0YXR1cyA9PSBIQURfRFJWX0RJU0NPTk5FQ1RFRCkgewo+ICAJCXNwaW5fdW5sb2NrX2ly cXJlc3RvcmUoJmludGVsaGFkZGF0YS0+aGFkX3NwaW5sb2NrLCBmbGFnX2lycXMpOwo+ICAJCXBy X2VycigiJXM6RGV2aWNlIGFscmVhZHkgZGlzY29ubmVjdGVkXG4iLCBfX2Z1bmNfXyk7Cj4gLQkJ cmV0dXJuIHJldHZhbDsKPiArCQlyZXR1cm4gMDsKPiAgCX0KPiAgCWJ1Zl9pZCA9IGludGVsaGFk ZGF0YS0+Y3Vycl9idWY7Cj4gIAlpbnRlbGhhZGRhdGEtPmJ1ZmZfZG9uZSA9IGJ1Zl9pZDsKPiBA QCAtMjgwLDcgKzI3OSw3IEBAIGludCBoYWRfcHJvY2Vzc19idWZmZXJfZG9uZShzdHJ1Y3Qgc25k X2kKPiAgCQlpZiAoIWludHJfY291bnQgfHwgKGludHJfY291bnQgPiAzKSkgewo+ICAJCQlwcl9l cnIoIkhBRCBTVyBzdGF0ZSBpbiBub24tcmVjb3ZlcmFibGUhISEgbW9kZVxuIik7Cj4gIAkJCXBy X2VycigiQWxyZWFkeSBwbGF5ZWQgc3RhbGUgZGF0YVxuIik7Cj4gLQkJCXJldHVybiByZXR2YWw7 Cj4gKwkJCXJldHVybiAwOwo+ICAJCX0KPiAgCQlidWZfaWQgKz0gKGludHJfY291bnQgLSAxKTsK PiAgCQlidWZfaWQgPSBidWZfaWQgJSA0Owo+IEBAIC0yOTgsNyArMjk3LDcgQEAgaW50IGhhZF9w cm9jZXNzX2J1ZmZlcl9kb25lKHN0cnVjdCBzbmRfaQo+IAo+ICAJaWYgKGhhZF9nZXRfaHdzdGF0 ZShpbnRlbGhhZGRhdGEpKSB7Cj4gIAkJcHJfZXJyKCJIRE1JIGNhYmxlIHBsdWdnZWQtb3V0XG4i KTsKPiAtCQlyZXR1cm4gcmV0dmFsOwo+ICsJCXJldHVybiAwOwo+ICAJfQo+IAo+ICAJLypSZXBy b2dyYW0gdGhlIHJlZ2lzdGVycyB3aXRoIGFkZHIgYW5kIGxlbmd0aCovCj4gQEAgLTMyMiwxMiAr MzIxLDExIEBAIGludCBoYWRfcHJvY2Vzc19idWZmZXJfZG9uZShzdHJ1Y3Qgc25kX2kKPiAgCQlz dHJlYW0tPnBlcmlvZF9lbGFwc2VkKHN0cmVhbS0+aGFkX3N1YnN0cmVhbSk7Cj4gIAl9Cj4gCj4g LQlyZXR1cm4gcmV0dmFsOwo+ICsJcmV0dXJuIDA7Cj4gIH0KPiAKPiAgaW50IGhhZF9wcm9jZXNz X2J1ZmZlcl91bmRlcnJ1bihzdHJ1Y3Qgc25kX2ludGVsaGFkICppbnRlbGhhZGRhdGEpCj4gIHsK PiAtCWludCByZXR2YWwgPSAwOwo+ICAJZW51bSBpbnRlbF9oYWRfYXVkX2J1Zl90eXBlIGJ1Zl9p ZDsKPiAgCXN0cnVjdCBwY21fc3RyZWFtX2luZm8gKnN0cmVhbTsKPiAgCXN0cnVjdCBoYWRfcHZ0 X2RhdGEgKmhhZF9zdHJlYW07Cj4gQEAgLTM1NSw3ICszNTMsNyBAQCBpbnQgaGFkX3Byb2Nlc3Nf YnVmZmVyX3VuZGVycnVuKHN0cnVjdCBzCj4gCj4gIAlpZiAoZHJ2X3N0YXR1cyA9PSBIQURfRFJW X0RJU0NPTk5FQ1RFRCkgewo+ICAJCXByX2VycigiJXM6RGV2aWNlIGFscmVhZHkgZGlzY29ubmVj dGVkXG4iLCBfX2Z1bmNfXyk7Cj4gLQkJcmV0dXJuIHJldHZhbDsKPiArCQlyZXR1cm4gMDsKPiAg CX0KPiAKPiAgCWlmIChzdHJlYW1fdHlwZSA9PSBIQURfUlVOTklOR19TVFJFQU0pIHsKPiBAQCAt MzY0LDEyICszNjIsMTEgQEAgaW50IGhhZF9wcm9jZXNzX2J1ZmZlcl91bmRlcnJ1bihzdHJ1Y3Qg cwo+ICAJCXN0cmVhbS0+cGVyaW9kX2VsYXBzZWQoc3RyZWFtLT5oYWRfc3Vic3RyZWFtKTsKPiAg CX0KPiAKPiAtCXJldHVybiByZXR2YWw7Cj4gKwlyZXR1cm4gMDsKPiAgfQo+IAo+ICBpbnQgaGFk X3Byb2Nlc3NfaG90X3BsdWcoc3RydWN0IHNuZF9pbnRlbGhhZCAqaW50ZWxoYWRkYXRhKQo+ICB7 Cj4gLQlpbnQgcmV0dmFsID0gMDsKPiAgCWVudW0gaW50ZWxfaGFkX2F1ZF9idWZfdHlwZSBidWZf aWQ7Cj4gIAlzdHJ1Y3Qgc25kX3BjbV9zdWJzdHJlYW0gKnN1YnN0cmVhbTsKPiAgCXN0cnVjdCBo YWRfcHZ0X2RhdGEgKmhhZF9zdHJlYW07Cj4gQEAgLTM4NCw3ICszODEsNyBAQCBpbnQgaGFkX3By b2Nlc3NfaG90X3BsdWcoc3RydWN0IHNuZF9pbnRlCj4gIAlpZiAoaW50ZWxoYWRkYXRhLT5kcnZf c3RhdHVzID09IEhBRF9EUlZfQ09OTkVDVEVEKSB7Cj4gIAkJcHJfZGVidWcoIkRldmljZSBhbHJl YWR5IGNvbm5lY3RlZFxuIik7Cj4gIAkJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmaW50ZWxoYWRk YXRhLT5oYWRfc3BpbmxvY2ssIGZsYWdfaXJxcyk7Cj4gLQkJcmV0dXJuIHJldHZhbDsKPiArCQly ZXR1cm4gMDsKPiAgCX0KPiAgCWJ1Zl9pZCA9IGludGVsaGFkZGF0YS0+Y3Vycl9idWY7Cj4gIAlp bnRlbGhhZGRhdGEtPmJ1ZmZfZG9uZSA9IGJ1Zl9pZDsKPiBAQCAtNDIyLDEyICs0MTksMTIgQEAg aW50IGhhZF9wcm9jZXNzX2hvdF9wbHVnKHN0cnVjdCBzbmRfaW50ZQo+IAo+ICAJaGFkX2J1aWxk X2NoYW5uZWxfYWxsb2NhdGlvbl9tYXAoaW50ZWxoYWRkYXRhKTsKPiAKPiAtCXJldHVybiByZXR2 YWw7Cj4gKwlyZXR1cm4gMDsKPiAKPiAgZXJyOgo+ICAJcG1fcnVudGltZV9kaXNhYmxlKGludGVs aGFkZGF0YS0+ZGV2KTsKPiAgCWludGVsaGFkZGF0YS0+ZGV2ID0gTlVMTDsKPiAtCXJldHVybiBy ZXR2YWw7Cj4gKwlyZXR1cm4gMDsKPiAgfQo+IAo+ICBpbnQgaGFkX3Byb2Nlc3NfaG90X3VucGx1 ZyhzdHJ1Y3Qgc25kX2ludGVsaGFkICppbnRlbGhhZGRhdGEpCj4gCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=