From: Takashi Iwai Subject: Re: [PATCH] pcm: returning semop error code for semaphore up/down failures. Date: Mon, 09 Jan 2017 13:52:40 +0100 Message-ID: References: <1483961051-24502-1-git-send-email-sutar.mounesh@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 47D7F266D05 for ; Mon, 9 Jan 2017 13:52:40 +0100 (CET) In-Reply-To: <1483961051-24502-1-git-send-email-sutar.mounesh@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: sutar.mounesh@gmail.com Cc: alsa-devel@alsa-project.org, mounesh_sutar@mentor.com List-Id: alsa-devel@alsa-project.org On Mon, 09 Jan 2017 12:24:11 +0100, sutar.mounesh@gmail.com wrote: > > From: Mounesh Sutar > > Signed-off-by: Mounesh Sutar > > diff --git a/src/pcm/pcm_direct.h b/src/pcm/pcm_direct.h > index 91e816c..a7c0439 100644 > --- a/src/pcm/pcm_direct.h > +++ b/src/pcm/pcm_direct.h > @@ -263,7 +263,12 @@ static inline int snd_pcm_direct_semaphore_down(snd_pcm_direct_t *dmix, int sem_ > { > struct sembuf op[2] = { { sem_num, 0, 0 }, { sem_num, 1, SEM_UNDO } }; > int err = semop(dmix->semid, op, 2); > - if (err == 0) dmix->locked[sem_num]++; > + if (err == 0) { > + dmix->locked[sem_num]++; > + } > + else if (err == -1) { > + err = -errno; > + } Just a minor coding style preference: no need for braces for a single line if/else in general. if (err == 0) dmix->locked[sem_num]++; else if (err == -1) err = -errno; thanks, Takashi > return err; > } > > @@ -271,7 +276,12 @@ static inline int snd_pcm_direct_semaphore_up(snd_pcm_direct_t *dmix, int sem_nu > { > struct sembuf op = { sem_num, -1, SEM_UNDO | IPC_NOWAIT }; > int err = semop(dmix->semid, &op, 1); > - if (err == 0) dmix->locked[sem_num]--; > + if (err == 0) { > + dmix->locked[sem_num]--; > + } > + else if (err == -1) { > + err = -errno; > + } > return err; > } > > -- > 2.7.4 >