From: Takashi Iwai Subject: Re: [PATCH] ALSA: hda - fix whitespaces Date: Thu, 09 Jun 2016 08:34:20 +0200 Message-ID: References: <1465453364-24323-1-git-send-email-vinod.koul@intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 5A3282657E5 for ; Thu, 9 Jun 2016 08:34:21 +0200 (CEST) In-Reply-To: <1465453364-24323-1-git-send-email-vinod.koul@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Vinod Koul Cc: patches.audio@intel.com, alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Thu, 09 Jun 2016 08:22:44 +0200, Vinod Koul wrote: > > Some trailing whitespaces seems to have crept in the hda_intel.c, > so fix them up > > Signed-off-by: Vinod Koul Well, this kind of "fix" doesn't improve readability but often makes stable backporting harder. So I'd like to skip it. This, of course, depends on the state of the code: for the code that is being actively rewritten, it's good to have such fixes. OTOH, for the longly maintained code, it's not clear whether to apply or not. thanks, Takashi > --- > sound/pci/hda/hda_intel.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > index 94089fc71884..5520082ad770 100644 > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -383,8 +383,8 @@ static char *driver_short_names[] = { > [AZX_DRIVER_SIS] = "HDA SIS966", > [AZX_DRIVER_ULI] = "HDA ULI M5461", > [AZX_DRIVER_NVIDIA] = "HDA NVidia", > - [AZX_DRIVER_TERA] = "HDA Teradici", > - [AZX_DRIVER_CTX] = "HDA Creative", > + [AZX_DRIVER_TERA] = "HDA Teradici", > + [AZX_DRIVER_CTX] = "HDA Creative", > [AZX_DRIVER_CTHDA] = "HDA Creative", > [AZX_DRIVER_CMEDIA] = "HDA C-Media", > [AZX_DRIVER_GENERIC] = "HD-Audio Generic", > -- > 1.9.1 >