From: Takashi Iwai Subject: Re: [PATCH 1/4] topology: Remove unused function write_data_block() Date: Wed, 18 Nov 2015 14:58:36 +0100 Message-ID: References: Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 773A6265894 for ; Wed, 18 Nov 2015 14:58:37 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: mengdong.lin@linux.intel.com Cc: vinod.koul@intel.com, mengdong.lin@intel.com, alsa-devel@alsa-project.org, subhransu.s.prusty@intel.com, liam.r.girdwood@intel.com List-Id: alsa-devel@alsa-project.org On Wed, 18 Nov 2015 08:22:59 +0100, mengdong.lin@linux.intel.com wrote: > > From: Mengdong Lin > > Fix gcc warning: 'write_data_block' defined but not used > [-Wunused-function]. > > Signed-off-by: Mengdong Lin I thought this was kept intentionally for the future use. But it's fine to remove if you are OK, of course. Applied now. Thanks. Takashi > > diff --git a/src/topology/builder.c b/src/topology/builder.c > index 154bd63..b0ba54e 100644 > --- a/src/topology/builder.c > +++ b/src/topology/builder.c > @@ -82,30 +82,6 @@ static int write_block_header(snd_tplg_t *tplg, unsigned int type, > return bytes; > } > > -static int write_data_block(snd_tplg_t *tplg, int size, int tplg_type, > - const char *obj_name, void *data) > -{ > - int ret; > - > - /* write the header for this block */ > - ret = write_block_header(tplg, tplg_type, 0, > - tplg->version, 0, size, 1); > - if (ret < 0) { > - SNDERR("error: failed to write %s block %d\n", obj_name, ret); > - return ret; > - } > - > - verbose(tplg, " %s : write %d bytes\n", obj_name, size); > - > - ret = write(tplg->out_fd, data, size); > - if (ret < 0) { > - SNDERR("error: failed to write %s %d\n", obj_name, ret); > - return ret; > - } > - > - return 0; > -} > - > static int write_elem_block(snd_tplg_t *tplg, > struct list_head *base, int size, int tplg_type, const char *obj_name) > { > -- > 2.5.0 >