From: Takashi Iwai Subject: Re: [PATCH v2] ALSA: PCM - Add PCM creation API for internal PCMs. Date: Thu, 09 Feb 2012 09:25:15 +0100 Message-ID: References: <1328733211-3234-1-git-send-email-lrg@ti.com> <20120208225728.GA6596@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 1C0D71038EB for ; Thu, 9 Feb 2012 09:25:18 +0100 (CET) In-Reply-To: <20120208225728.GA6596@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, Liam Girdwood List-Id: alsa-devel@alsa-project.org At Wed, 8 Feb 2012 22:57:34 +0000, Mark Brown wrote: > > [1 ] > On Wed, Feb 08, 2012 at 10:35:57PM +0100, Takashi Iwai wrote: > > At Wed, 8 Feb 2012 20:33:31 +0000, > > Liam Girdwood wrote: > > > > The new ASoC dynamic PCM core needs to create PCMs and substreams that are > > > for use by internal ASoC drivers only and not visible to userspace for > > > direct IO. These new PCMs are similar to regular PCMs expect they have no > > > device nodes or procfs entries. The ASoC component drivers use them in exactly > > > the same way as regular PCMs for PCM and DAI operations. > > > The changes look OK to me, but could you fix a few errors/warnings > > by checkpatch.pl? > > Since Liam's got a whole raft of ASoC changes depending on this one can > you please either apply it to a branch or ack it for merge via ASoC? OK, now I fixed coding-style issues by myself and applied the patch. It's found in an individual branch, topic/pcm-internal of sound git tree. Feel free to pull this branch to your trees. Takashi