From: Takashi Iwai Subject: Re: [PATCH v3] sound/soc/codecs: add LAPIS Semiconductor ML26124 Date: Thu, 01 Dec 2011 08:40:38 +0100 Message-ID: References: <1322474755-18785-1-git-send-email-tomoya.rohm@gmail.com> <20111128132317.GD8275@opensource.wolfsonmicro.com> <20111129122916.GM2851@opensource.wolfsonmicro.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 06415103847 for ; Thu, 1 Dec 2011 08:40:40 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Tomoya MORINAGA Cc: Dimitris Papastamos , alsa-devel@alsa-project.org, Lars-Peter Clausen , Mike Frysinger , qi.wang@intel.com, Mark Brown , linux-kernel@vger.kernel.org, yong.y.wang@intel.com, kok.howg.ewe@intel.com, Daniel Mack , Liam Girdwood , joel.clark@intel.com List-Id: alsa-devel@alsa-project.org At Thu, 1 Dec 2011 16:34:14 +0900, Tomoya MORINAGA wrote: > > 2011/11/29 Mark Brown :> > These > should mathc. > > Match. > > Sorry, still I couldn't understand. > What does your "match" mean for anything? You need to have read Mark's comment carefully. He quoted another line before that. ================================================================ > + SOC_SINGLE_TLV("EQ Band1 Input Volume", ML26124_EQ_GAIN_BRAND1, 0, > + 0xff, 1, eq_band_gain), > + SOC_SINGLE("EQ BAND1 Switch", ML26124_FILTER_EN, 3, 1, 0), These should mathc. ================================================================ So, you have two inconsistent names for EQ band1. Takashi