From: Takashi Iwai Subject: Re: A plea for help on mixer support for Fast Track Ultra (8R) Date: Thu, 19 May 2011 07:42:15 +0200 Message-ID: References: <4DD3E39D.30100@showlabor.de> <4DD413FC.2090808@showlabor.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id D5E28103850 for ; Thu, 19 May 2011 07:42:17 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Daniel Mack Cc: alsa-devel@alsa-project.org, Grant Diffey , Felix Homann List-Id: alsa-devel@alsa-project.org At Wed, 18 May 2011 23:30:46 +0200, Daniel Mack wrote: > > > The main problem at the moment is that snd_usb_create_mixer() will not be > > called on quirked devices! Take a look at card.c: snd_usb_create_mixer() > > will only be called if snd_usb_create_quirk() returns > 0. But why should we > > assume that quirked devices don't have any mixers? > > That is indeed strange, yes. I can't explain that. Not to break > existing devices, I would suggest adding a bit-wise "flags" field to > snd_usb_audio_quirk and still create the mixers if a certain flag > (something like "QUIRK_FLAG_CREATE_STANDARD_MIXERS") is set. Clemens, > Takashi, would that be ok? Returning zero means that you don't follow any standard. In the comment of snd_usb_create_quirk: /* * audio-interface quirks * * returns zero if no standard audio/MIDI parsing is needed. * returns a positive value if standard audio/midi interfaces are parsed * after this. * returns a negative value at error. */ I see no big reason to make things more complex. If you want to avoid the standard audio parsing after quirk but only parse mixer, just call snd_usb_create_mixer() in your quirk function. thanks, Takashi