From: Takashi Iwai Subject: Re: [PATCH 1/1] echomixer: Fix echomixer to work with the new drivers Date: Mon, 16 Mar 2009 08:50:34 +0100 Message-ID: References: <20090315213509.76f05f29.pochini@shiny.it> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx1.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id 5918B103816 for ; Mon, 16 Mar 2009 08:51:00 +0100 (CET) In-Reply-To: <20090315213509.76f05f29.pochini@shiny.it> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Giuliano Pochini Cc: Alsa-devel List-Id: alsa-devel@alsa-project.org At Sun, 15 Mar 2009 21:35:09 +0100, Giuliano Pochini wrote: > > There is a long standing bug in the drivers for cards with a vmixer because > I overlooked a detail in the c++ generic driver by echoaudio. Those cards > do not have a line-out volume control. It is a virtual control provided by > the generic driver. The bug is harmless because the DSP just ignores the > command to change the volume. > Since that control has been removed, echomixer must be updated. With this > patch it uses the vmixer to fake the line-out volume. > > > This patch makes echomixer work with the new drivers. > > Signed-off-by Giuliano Pochini Applied now. Thanks. (BTW, don't forget a colon after Signed-off-by.) Takashi