From: Takashi Iwai Subject: Re: [PATCH] hda: STAC927x power management Date: Thu, 21 Feb 2008 08:04:51 +0100 Message-ID: References: <47BCA307.4000608@embeddedalley.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (ns.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id 213CA2417D for ; Thu, 21 Feb 2008 08:04:52 +0100 (CET) In-Reply-To: <47BCA307.4000608@embeddedalley.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Matthew Ranostay Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Wed, 20 Feb 2008 17:00:39 -0500, Matthew Ranostay wrote: > > Fix issue on STAC927x codecs that first DAC was getting powered down even if was being used. > > Signed-off-by: Matthew Ranostay Thanks, applied now to HG tree. I guess we can use check_in_dac_nids() instead? Takashi > --- > diff -r 30701aaf404c pci/hda/patch_sigmatel.c > --- a/pci/hda/patch_sigmatel.c Wed Feb 20 12:13:29 2008 +0100 > +++ b/pci/hda/patch_sigmatel.c Wed Feb 20 14:16:59 2008 -0700 > @@ -2893,7 +2893,8 @@ static void stac92xx_power_down(struct h > /* power down inactive DACs */ > hda_nid_t *dac; > for (dac = spec->dac_list; *dac; dac++) > - if (!is_in_dac_nids(spec, *dac)) > + if (!is_in_dac_nids(spec, *dac) && > + spec->multiout.hp_nid != *dac) > snd_hda_codec_write_cache(codec, *dac, 0, > AC_VERB_SET_POWER_STATE, AC_PWRST_D3); > } >