From: Takashi Iwai Subject: Re: [Patch] _snd_cmipci_uswitch_put doesn't set zero flags Date: Wed, 20 Dec 2006 19:28:19 +0100 Message-ID: References: <45896034.8030705@ipi.ac.ru> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <45896034.8030705@ipi.ac.ru> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@lists.sourceforge.net Errors-To: alsa-devel-bounces@lists.sourceforge.net To: "Timofei V. Bondarenko" Cc: alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Wed, 20 Dec 2006 19:09:24 +0300, Timofei V. Bondarenko wrote: > > Hi. > > Playing with spdif output on cmipci i've noticed the SPDO5V option does > not change appropriate bits the register. > > The _snd_cmipci_uswitch_put checks the change in flags in wrong way. > If 'active' state of an option corresponds to a _zero_ bits in a hw > register then function fails. The SPDO5V is the sample. > In the most cases 'active' state of option is set through an non-zerio > bits in a register. This case works fine. > > The fix attached. > Unfortunately i was unable to change spdif output voltage anyway. > Although the register changes right at least. Thanks, I applied it to HG tree now. Takashi ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV