From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] sparc dbri: hardware constrains added
Date: Wed, 23 Aug 2006 11:39:31 +0200
Message-ID: <s5hhd03ssdo.wl%tiwai@suse.de>
References: <44eb445108302@wp.pl>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
In-Reply-To: <44eb445108302@wp.pl>
Sender: alsa-devel-bounces@lists.sourceforge.net
Errors-To: alsa-devel-bounces@lists.sourceforge.net
To: Krzysztof Helt <krzysztof.h1@wp.pl>
Cc: alsa-devel <alsa-devel@lists.sourceforge.net>

At Tue, 22 Aug 2006 19:52:17 +0200,
Krzysztof Helt wrote:
> 
> From: Krzysztof Helt (krzysztof.h1@wp.pl)
> 
> This patch adds ALSA hardware constrains so stereo is possible
> only with 16-bit format. It contains small cleanups to ring
> buffered code as well.
> 
> Signed-off-by: Krzysztof Helt (krzysztof.h1@wp.pl)

Missing braces in debug prints of dbri_cmdsend(), but others look
fine.  I queued the fixed patch on my tree.  Will be committed to the
upstream soon.

BTW, dprintk() should use "do { } while (0)" so that it can be used 
safely without extra blocks.


Thanks,

Takashi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642