From: Takashi Iwai Subject: Re: Building ALSA away from the source tree: some patches Date: Tue, 23 Aug 2005 12:34:26 +0200 Message-ID: References: <43026EFB.9030802@brenda-arkle.demon.co.uk> <430A3CE2.30900@brenda-arkle.demon.co.uk> <430AFA55.2070108@brenda-arkle.demon.co.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <430AFA55.2070108@brenda-arkle.demon.co.uk> Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Bernard Leak Cc: alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Tue, 23 Aug 2005 11:28:37 +0100, Bernard Leak wrote: > > Dear List, > > Takashi Iwai wrote > > >Thanks. But please attach one patch per one file. > >Also, don't forget to add the description of the patch (to commit as > >the changelog). > > > > > > Aargh! I shouldn't send patches so late at night: > I misunderstood/forgot/went blank on the instructions. Ah, no, I meant to split the patches to alsa-lib and alsa-utils, since they are basically different trees. The changes to a single tree for a single purpose should be to a single patch (unless it becomes too big). > I am very likely being dense here, but it is not > obvious *how* I specify a description to use as > a CVS commitment comment... A quick scan of > recent threads with patches attached seems not > to help. > > I suggest: > Allow separate build and source trees > > ... which will do for both alsa-lib and alsa-utils, > though the patches for these two packages are independent. It's enough, thanks. One question: > --- alsa-lib-1.0.9/src/Makefile.am-old 2005-05-10 11:52:30.000000000 +0100 > +++ alsa-lib-1.0.9/src/Makefile.am 2005-08-16 21:38:08.000000000 +0100 > @@ -1,9 +1,9 @@ > SUBDIRS=control mixer ordinary_mixer pcm ordinary_pcm rawmidi timer hwdep seq instr compat conf alisp > -EXTRA_DIST=Versions > +EXTRA_DIST=$(srcdir)/Versions Do we need this really? Others look fine. I'll apply to CVS tree, together with some fixes for the latest CVS version. Takashi ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf