Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D5C7C433E0 for ; Tue, 26 May 2020 10:54:24 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C76762086A for ; Tue, 26 May 2020 10:54:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="iniaWqpt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C76762086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 09026171C; Tue, 26 May 2020 12:53:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 09026171C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1590490462; bh=8yUOlndPaESOZUnp0AdZTAudDlgP7oYMkjYzSFTj1Dk=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=iniaWqptRniFCo2APxy/lnr2TfmC4rFNUqMmh7Y1wHV5IzjJ4E/IeAoCAWFQeRjw4 UpPWxcAolG5Qnd8jSW/eHk8oBVsu/913NzLMBQRhJbaRhO5EH0e/IeFPLiVQjWv4Fh CE9uC91O9IgDj2mFewoYf/FR7kBFKWaNXiRpRhYY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 860E6F80131; Tue, 26 May 2020 12:53:31 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2454FF80150; Tue, 26 May 2020 12:53:30 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 76538F80131 for ; Tue, 26 May 2020 12:53:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 76538F80131 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 886DCB234; Tue, 26 May 2020 10:53:25 +0000 (UTC) Date: Tue, 26 May 2020 12:53:22 +0200 Message-ID: From: Takashi Iwai To: Mark Pearson Subject: Re: [External] [PATCH] ALSA: hda/realtek - Add a model for Thinkpad T570 without DAC workaround In-Reply-To: References: <20200526062406.9799-1-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: "alsa-devel@alsa-project.org" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 26 May 2020 12:48:20 +0200, Mark Pearson wrote: > > Hi > > > -----Original Message----- > > From: Alsa-devel On Behalf Of > > Takashi Iwai > > Sent: Tuesday, May 26, 2020 2:24 AM > > > > We fixed the regression of the speaker volume for some Thinkpad models > > (e.g. T570) by the commit 54947cd64c1b ("ALSA: hda/realtek - Fix > > speaker output regression on Thinkpad T570"). Essentially it fixes > > the DAC / pin pairing by a static table. It was confirmed and merged > > to stable kernel later. > > > > Now, interestingly, we got another regression report for the very same > > model (T570) about the similar problem, and the commit above was the > > culprit. That is, by some reason, there are devices that prefer the > > DAC1, and another device DAC2! > > > > Unfortunately those have the same ID and we have no idea what can > > differentiate, in this patch, a new fixup model "tpt470-dock-fix" is > > provided, so that users with such a machine can apply it manually. > > When model=tpt470-dock-fix option is passed to snd-hda-intel module, > > it avoids the fixed DAC pairing and the DAC1 is assigned to the > > speaker like the earlier versions. > > > That's interesting - let me follow up with the HW team and see if I can > find out why this is. It would be nice to have something that works for > all cases automatically. That'd be appreciated, thanks! Takashi