From: Takashi Iwai Subject: Re: [PATCH] ALSA: seq: Fix use-after-free at creating a port Date: Wed, 11 Oct 2017 20:05:08 +0200 Message-ID: References: <20171011080019.16212-1-tiwai@suse.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id C233A2675CB for ; Wed, 11 Oct 2017 20:05:09 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Linus Torvalds Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Michael23 Yu List-Id: alsa-devel@alsa-project.org On Wed, 11 Oct 2017 19:35:46 +0200, Linus Torvalds wrote: > > On Wed, Oct 11, 2017 at 1:00 AM, Takashi Iwai wrote: > > There is a potential race window opened at creating and deleting a > > port via ioctl, as spotted by fuzzing. [..] > > I'm assuming I'll just get this through the normal sound fixes pull request? Yes, I'll send you a pull request tomorrow together with other fixes. > Also, just for future issues, I really wish people would edit the call > traces to be a bit more legible. You did remove some of the excessive > KASAN noise, but the stack trace hex numbers are a bit distracting > too. > > Of course, the only reason those hex numbers are there in the first > place was that the oops was generated with an older kernel - we don't > even print them out any more. > > Not a big deal, but I thought I'd mention it just because I generally > encourage people to try to edit down oopses etc to the really relevant > parts (the kernel often spits out a lot of stuff that isn't really > relevant for the particular bug, because it *might* be) OK, noted. Now after seeing lots of commits with stack trace messages in this week (I warn you beforehand!), I share the same feeling. Will tidy up harder at the next time. Thanks! Takashi