From: Takashi Iwai Subject: Re: [PATCH v2 2/2] conf: topology: Generate Private data binary blobs Date: Tue, 05 Apr 2016 22:10:48 +0200 Message-ID: References: <1459833605-11223-1-git-send-email-vinod.koul@intel.com> <1459833605-11223-3-git-send-email-vinod.koul@intel.com> <1459867127.3136.39.camel@intel.com> <1459871538.3136.42.camel@intel.com> <1459872533.3136.49.camel@intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 3388A26070F for ; Tue, 5 Apr 2016 22:10:50 +0200 (CEST) In-Reply-To: <1459872533.3136.49.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: "Koul, Vinod" Cc: "liam.r.girdwood@linux.intel.com" , Patches Audio , "alsa-devel@alsa-project.org" , "broonie@kernel.org" , "Nc, Shreyas" List-Id: alsa-devel@alsa-project.org On Tue, 05 Apr 2016 18:08:55 +0200, Koul, Vinod wrote: > > On Tue, 2016-04-05 at 18:05 +0200, Takashi Iwai wrote: > > On Tue, 05 Apr 2016 17:52:19 +0200, > > Koul, Vinod wrote: > > > > > > On Tue, 2016-04-05 at 16:45 +0200, Takashi Iwai wrote: > > > > > There is no special dependency here, so we can just add > > > > > > src/conf/toplogty/*/data/Makefile.am in the toplevel > > > > > > configure.ac? > > > > > > > > > > Yes that seems better. Also please note if we do that alsa-lib > > > > > can > > > > > compile the data before it compiles skl topology so we can get > > > > > rid > > > > > of > > > > > bnary blobs whcih are prebuilt and get them generated on alsa > > > > > -lib > > > > > compile. > > > > > > > > Yeah, that's nicer, too. > > > > > > One thing though we need to run the binary to generate blobs, am > > > thinking of hooking that up with install step. > > > > Compiling something at installation is wrong in general. > > Nope that's not what I meant. > > We will compile the tool and create the binary at alsa-lib compile step. > > Then we need to run that to generate the binary blobs and that can be > done at install step OK. But now I noticed another pitfall. The topology firmware is endian-sensitive, and the code to generate is so, too. Thus it can't work for big-endian architectures. One solution would be to bundle the firmware binary and provide the generator code as a supplement like the current version. Another option would be to check the endianess in configure script and limit the intel topology f/w only for little endian via AM_CONDITIONAL(). Takashi