From: Takashi Iwai Subject: Re: [PATCH 1/4] ALSA: line6: Add toneport_has_source_select() Date: Fri, 06 Feb 2015 15:56:15 +0100 Message-ID: References: <1423234272-7348-1-git-send-email-chris@rorvick.com> <1423234272-7348-2-git-send-email-chris@rorvick.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <1423234272-7348-2-git-send-email-chris@rorvick.com> Sender: linux-kernel-owner@vger.kernel.org To: Chris Rorvick Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Stefan Hajnoczi List-Id: alsa-devel@alsa-project.org At Fri, 6 Feb 2015 08:51:09 -0600, Chris Rorvick wrote: > > Add a predicate for testing if the device supports source selection to > make the conditional logic around this a bit cleaner. > > Signed-off-by: Chris Rorvick > --- > sound/usb/line6/toneport.c | 32 ++++++++++++++++---------------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git a/sound/usb/line6/toneport.c b/sound/usb/line6/toneport.c > index b107cf4..de56180a 100644 > --- a/sound/usb/line6/toneport.c > +++ b/sound/usb/line6/toneport.c > @@ -343,6 +343,20 @@ static void toneport_remove_leds(struct usb_line6_toneport *toneport) > } > } > > +static bool toneport_has_source_select(struct usb_line6_toneport *toneport) > +{ > + switch (toneport->type) { > + case LINE6_TONEPORT_UX1: > + case LINE6_TONEPORT_UX2: > + case LINE6_PODSTUDIO_UX1: > + case LINE6_PODSTUDIO_UX2: > + return 1; > + > + default: > + return 0; Please use true and false. Takashi