From: Takashi Iwai Subject: Re: [RFC] compress: add support for gapless playback Date: Wed, 06 Feb 2013 15:14:22 +0100 Message-ID: References: <1360074085-562-1-git-send-email-vinod.koul@intel.com> <5111C39A.6020805@linux.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 1EABB26509C for ; Wed, 6 Feb 2013 15:14:23 +0100 (CET) In-Reply-To: <5111C39A.6020805@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Pierre-Louis Bossart Cc: Vinod Koul , Jeeja KP , alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com, liam.r.girdwood@intel.com List-Id: alsa-devel@alsa-project.org At Tue, 05 Feb 2013 20:44:42 -0600, Pierre-Louis Bossart wrote: > > > /** > > + * struct snd_compr_metadata: compressed stream metadata > > + * @encoder_delay: no of samples inserted by the encoder at the beginning > > + * of the track > > + * @encoder_padding: no of samples appended by the encoder at the end > > + * of the track > > + */ > > +struct snd_compr_metadata { > > + __u32 encoder_delay; > > + __u32 encoder_padding; > > +}; > > You need to pad this structure with reserved bytes for future > evolutions. Things like ReplayGain, etc, might be of interest for some > implementations. Let's not be cheap here Or, make it a single key/value. User-space can call the ioctl multiple times with different key/value pairs. (BTW, don't you need get_metadata? IMO, it was a mistake that we didn't provide get_* variants for PCM parameters.) thanks, Takashi