From: Takashi Iwai Subject: Re: Fix section mismatch in wm8995.c Date: Tue, 11 Jan 2011 18:32:32 +0100 Message-ID: References: <20110111171013.GK6541@sirena.org.uk> <20110111172839.GE13429@opensource.wolfsonmicro.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id E2AC810386B for ; Tue, 11 Jan 2011 18:32:32 +0100 (CET) In-Reply-To: <20110111172839.GE13429@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Dimitris Papastamos , alsa-devel@alsa-project.org, Liam Girdwood List-Id: alsa-devel@alsa-project.org At Tue, 11 Jan 2011 17:28:40 +0000, Mark Brown wrote: > > On Tue, Jan 11, 2011 at 06:18:49PM +0100, Takashi Iwai wrote: > > Mark Brown wrote: > > > > Hrm, it'd be better to find some annotation for the pointer which lets > > > us have the reference. We at a higher level only dereference the > > > pointer from the probe path, preventing the discard isn't a great > > > solution. > > > Nah, that's way too complex for the time being. I really prefer a > > warning-less code for such a case. > > The array is ~25k so it's not a completely trivial amount of memory, > unfortunately. Hm. But, it's same for (some) other codecs, no? If we do annotate something, we should mark all these at once. > > The whole __init stuff have lots of potential improvements. But, > > improving it would cost pretty much. And we don't want yet another > > new annotation... > > Very true. The other option is to refactor all the data structures to > appease it which is painful. Agreed. Takashi