From: Takashi Iwai Subject: Re: [PATCH 2/8] ASoC pxa2xx I2S support Date: Tue, 10 Oct 2006 19:06:59 +0200 Message-ID: References: <1160496714.24436.111.camel@localhost.localdomain> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1160496714.24436.111.camel@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@lists.sourceforge.net Errors-To: alsa-devel-bounces@lists.sourceforge.net To: Liam Girdwood Cc: alsa-devel List-Id: alsa-devel@alsa-project.org At Tue, 10 Oct 2006 17:11:54 +0100, Liam Girdwood wrote: > > +/* used to disable sysclk if external crystal is used */ > +static int extclk = 0; You can omit "= 0" for zero-initialization of a static variable. > +static int pxa2xx_i2s_hw_params(struct snd_pcm_substream *substream, > + struct snd_pcm_hw_params *params) > +{ > + struct snd_soc_pcm_runtime *rtd = substream->private_data; > + > + pxa_i2s.master = 0; > + if (rtd->cpu_dai->dai_runtime.fmt & SND_SOC_DAIFMT_CBS_CFS) > + pxa_i2s.master = 1; > + > + if (pxa_i2s.master && !extclk) { > + pxa_gpio_mode(gpio_bus[pxa_i2s.master].sys); > + } Remove braces. Takashi ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV