From: Takashi Iwai Subject: Re: Odd no-op in sound/pci/hda/patch_sigmatel.c Date: Mon, 05 Jan 2015 13:27:10 +0100 Message-ID: References: <87fvbpxvsy.fsf@rasmusvillemoes.dk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id A543A265083 for ; Mon, 5 Jan 2015 13:27:10 +0100 (CET) In-Reply-To: <87fvbpxvsy.fsf@rasmusvillemoes.dk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Rasmus Villemoes Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Mon, 05 Jan 2015 13:21:17 +0100, Rasmus Villemoes wrote: > > Hi Takashi > > The "spec->gpio_mask &= spec->gpio_mask" on line 571 of > sound/pci/hda/patch_sigmatel.c is obviously a no-op. Is that on purpose, > or was it supposed to be something else? It's obviously a copy&paste error. The correct code would be: diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index 4f6413e01c13..605d14003d25 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -568,9 +568,9 @@ static void stac_store_hints(struct hda_codec *codec) spec->gpio_mask; } if (get_int_hint(codec, "gpio_dir", &spec->gpio_dir)) - spec->gpio_mask &= spec->gpio_mask; - if (get_int_hint(codec, "gpio_data", &spec->gpio_data)) spec->gpio_dir &= spec->gpio_mask; + if (get_int_hint(codec, "gpio_data", &spec->gpio_data)) + spec->gpio_data &= spec->gpio_mask; if (get_int_hint(codec, "eapd_mask", &spec->eapd_mask)) spec->eapd_mask &= spec->gpio_mask; if (get_int_hint(codec, "gpio_mute", &spec->gpio_mute)) I'll fix this with your reported-by credit. thanks, Takashi