From: Takashi Iwai Subject: Re: [PATCH] ALSA: pcm: Remove unused functions declaration Date: Sat, 03 Jan 2015 21:03:52 +0100 Message-ID: References: <1420304174-4078-1-git-send-email-lars@metafoo.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 26A4F2604B1 for ; Sat, 3 Jan 2015 21:03:53 +0100 (CET) In-Reply-To: <1420304174-4078-1-git-send-email-lars@metafoo.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Lars-Peter Clausen Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Sat, 3 Jan 2015 17:56:14 +0100, Lars-Peter Clausen wrote: > > Remove function declarations for functions that don't have a matching > implementation. > > For snd_pcm_build_linear_format the implementation was removed in > 64d27f96cb719cf8 ("[ALSA] Support 3-bytes 24bit format in PCM OSS > emulation"). All the others never had one (as far as git history goes). > > Signed-off-by: Lars-Peter Clausen Wow, such an archaeological discovery. Applied now. Thanks for cleanups. Takashi > --- > include/sound/pcm.h | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/include/sound/pcm.h b/include/sound/pcm.h > index bf32cea..cd09c1b 100644 > --- a/include/sound/pcm.h > +++ b/include/sound/pcm.h > @@ -518,7 +518,6 @@ void snd_pcm_release_substream(struct snd_pcm_substream *substream); > int snd_pcm_attach_substream(struct snd_pcm *pcm, int stream, struct file *file, > struct snd_pcm_substream **rsubstream); > void snd_pcm_detach_substream(struct snd_pcm_substream *substream); > -void snd_pcm_vma_notify_data(void *client, void *data); > int snd_pcm_mmap_data(struct snd_pcm_substream *substream, struct file *file, struct vm_area_struct *area); > > > @@ -984,21 +983,15 @@ int snd_pcm_format_physical_width(snd_pcm_format_t format); /* in bits */ > ssize_t snd_pcm_format_size(snd_pcm_format_t format, size_t samples); > const unsigned char *snd_pcm_format_silence_64(snd_pcm_format_t format); > int snd_pcm_format_set_silence(snd_pcm_format_t format, void *buf, unsigned int frames); > -snd_pcm_format_t snd_pcm_build_linear_format(int width, int unsigned, int big_endian); > > void snd_pcm_set_ops(struct snd_pcm * pcm, int direction, > const struct snd_pcm_ops *ops); > void snd_pcm_set_sync(struct snd_pcm_substream *substream); > -int snd_pcm_lib_interleave_len(struct snd_pcm_substream *substream); > int snd_pcm_lib_ioctl(struct snd_pcm_substream *substream, > unsigned int cmd, void *arg); > int snd_pcm_update_state(struct snd_pcm_substream *substream, > struct snd_pcm_runtime *runtime); > int snd_pcm_update_hw_ptr(struct snd_pcm_substream *substream); > -int snd_pcm_playback_xrun_check(struct snd_pcm_substream *substream); > -int snd_pcm_capture_xrun_check(struct snd_pcm_substream *substream); > -int snd_pcm_playback_xrun_asap(struct snd_pcm_substream *substream); > -int snd_pcm_capture_xrun_asap(struct snd_pcm_substream *substream); > void snd_pcm_playback_silence(struct snd_pcm_substream *substream, snd_pcm_uframes_t new_hw_ptr); > void snd_pcm_period_elapsed(struct snd_pcm_substream *substream); > snd_pcm_sframes_t snd_pcm_lib_write(struct snd_pcm_substream *substream, > -- > 1.8.0 >