From: Takashi Iwai Subject: Re: [PATCH] ucm: change msleep to usleep Date: Fri, 19 Aug 2011 10:21:10 +0200 Message-ID: References: <20110819072217.4790.29949.stgit@localhost6.localdomain6> <20110819081306.GD3943@guanqun-laptop.sh.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 41BDD103905 for ; Fri, 19 Aug 2011 10:21:13 +0200 (CEST) In-Reply-To: <20110819081306.GD3943@guanqun-laptop.sh.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Lu Guanqun Cc: ALSA List-Id: alsa-devel@alsa-project.org At Fri, 19 Aug 2011 16:13:06 +0800, Lu Guanqun wrote: > > Hi Takashi, > > On Fri, Aug 19, 2011 at 03:40:37PM +0800, Takashi Iwai wrote: > > At Fri, 19 Aug 2011 15:22:17 +0800, > > Lu Guanqun wrote: > > > > > > In file src/ucm/parser.c: > > > if (strcmp(cmd, "usleep") == 0) { > > > string `usleep' is compared, however, in the comment and example conf file, > > > `msleep' is used, it's better to unify them all. > > > > Don't we scale the value appropriately (although it's just a demo)? > > No. Then taking over the value as is doesn't look correct. Takashi