From: Takashi Iwai Subject: Re: [PATCH 1/2] Echoaudio: Add support for Indigo express cards Date: Mon, 16 Mar 2009 08:45:07 +0100 Message-ID: References: <20090315213642.6a841b73.pochini@shiny.it> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (ns2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 65C6D10380E for ; Mon, 16 Mar 2009 08:45:07 +0100 (CET) In-Reply-To: <20090315213642.6a841b73.pochini@shiny.it> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Giuliano Pochini Cc: Alsa-devel List-Id: alsa-devel@alsa-project.org At Sun, 15 Mar 2009 21:36:42 +0100, Giuliano Pochini wrote: > > This patch adds support for IndigoIOx and IndigoDJx. I tested IndigoIOx > myself, and Carmen Rocco tested the IndigoDJx. It wasn't tested > extensively, but I think it stable enough. Maybe you want to mark it as > experimental anyway. The soundcard matrix should be updated as well, but > the page is locked. These two cards have the same features of their > respective CARDBUS versions. The links to the manufacturer's site are: > http://www.echoaudio.com/Products/ExpressCard/IndigoDJx/ and > http://www.echoaudio.com/Products/ExpressCard/IndigoIOx/ . > > I want to thank Echoaudio again for their support. > > > This patch adds support for IndigoIOx and IndigoDJx. > > Signed-off-by Giuliano Pochini The code looks almost good, but could you do the following? - split to two patches, one for kernel tree and one for alsa-driver tree - run checkpatch.pl against the patch and fix issues reported there thanks, Takashi