From: Takashi Iwai Subject: Re: S16_LE + softvol = bad Date: Wed, 23 Jan 2008 12:31:26 +0100 Message-ID: References: <1200578447.2521.1231765977@webmail.messagingengine.com> <4797234A.10007@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 0270A1037F8 for ; Wed, 23 Jan 2008 12:31:27 +0100 (CET) In-Reply-To: <4797234A.10007@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: "Alexander E. Patrakov" Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Wed, 23 Jan 2008 16:21:46 +0500, Alexander E. Patrakov wrote: > > Takashi Iwai wrote: > > At Thu, 17 Jan 2008 20:01:09 +0500, > > Alexander E. Patrakov wrote: > >> 2008/1/17, Takashi Iwai : > >>> ... and the below is the fix. Give it a try. > >> Tested with no explicit defaults.pcm.dmix.format, with explicit > >> S16_LE, and with explicit S32_LE, all with Intel HD audio and the PC > >> speaker (total 6 cases, including one meaningless). In all cases, the > >> code was able to choose the correct format for talking with hardware > >> (i.e., the worst of (a) explicitly specified, if any, and (b) the best > >> hardware-supported one). Thanks for a quick fix! > > > > Thanks for checking. I applied it to HG tree now. > > Could you please apply the same tweak (use the best available sample format > unless overridden) to dsnoop, too? Done. Takashi