Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C917C4320E for ; Fri, 30 Jul 2021 07:43:29 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D35061019 for ; Fri, 30 Jul 2021 07:43:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2D35061019 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0562919FD; Fri, 30 Jul 2021 09:42:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0562919FD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1627631005; bh=hR6bDS0ivDICK2Jjm7Uvyezpm6nEHokP3scDVwkAiC4=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=bdSqN85XLwL+FgXWeeG6CmF05dHN5tYwZHP7r52SKRKjzZX/7nAR1S7ck/gLKkiTu oWkewNaTcUGW/z06G/DQruvmItUC4R907Xa0FgvwM8xN2eIVhQe8jrRMGs1JIfI3kw CLJ5z+xG0tlj84MhSxU0EUj0HWDqZ7pm7c63epHU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 88C14F80212; Fri, 30 Jul 2021 09:42:34 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7FBDEF80253; Fri, 30 Jul 2021 09:42:31 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5C09EF800E9 for ; Fri, 30 Jul 2021 09:42:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5C09EF800E9 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="V/WgGWB9"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="ApWNuJLv" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 1DCDD221F3; Fri, 30 Jul 2021 07:42:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1627630943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fyq6npB5RywaGIA8Oa4z0S00Qtid5lwfscd6kyNIFWU=; b=V/WgGWB9SkXwuHN5Najhc/6pPshl6v/gwndIxuDvzJ2wOtqAvWEnP5Hntke+YwaZEGWd/r 3AcxFz10i7jDboXhuKsRz4oM3s16B5GTHM0Xo7sG8DXgqnxs78cMCEj4YkJh5Iqepo9CLt wC81K31R6EOCM8m/DHpHSwOLptXaGvs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1627630943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fyq6npB5RywaGIA8Oa4z0S00Qtid5lwfscd6kyNIFWU=; b=ApWNuJLvnm5UgkeTVjy9MP9KjaQhTqiIZFBV5Wh2sgNfe5LYca8bBG6F+OlZmjBRcr7nJx J9jr4yxWfR8UTlBQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 1551AA3B88; Fri, 30 Jul 2021 07:42:23 +0000 (UTC) Date: Fri, 30 Jul 2021 09:42:23 +0200 Message-ID: From: Takashi Iwai To: Jaroslav Kysela Subject: Re: [PATCH] ALSA: pcm: Fix mmap capability check In-Reply-To: References: <20210720092640.12338-1-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 30 Jul 2021 09:19:16 +0200, Jaroslav Kysela wrote: > > On 20. 07. 21 11:26, Takashi Iwai wrote: > > The hw_support_mmap() doesn't cover all memory allocation types and > > might use a wrong device pointer for checking the capability. > > Check the all memory allocation types more completely. > > This change breaks mmap for the snd-dummy driver (fake_buffer). It seems that > we need this fix? > > diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c > index 6a2971a7e6a1..09c0e2a6489c 100644 > --- a/sound/core/pcm_native.c > +++ b/sound/core/pcm_native.c > @@ -246,7 +246,7 @@ static bool hw_support_mmap(struct snd_pcm_substream > *substream) > if (!(substream->runtime->hw.info & SNDRV_PCM_INFO_MMAP)) > return false; > > - if (substream->ops->mmap) > + if (substream->ops->mmap || substream->ops->page) > return true; > > switch (substream->dma_buffer.dev.type) { Yes, that would work. Or allowing the mmap for unknown buffer type by blindly relying to the hw.info flag. But ops->page check looks safer. Care to submit a proper patch? Thanks! Takashi