Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1074EC07E99 for ; Mon, 12 Jul 2021 11:12:54 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82A4C60FED for ; Mon, 12 Jul 2021 11:12:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82A4C60FED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2CAA2168F; Mon, 12 Jul 2021 13:12:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2CAA2168F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1626088370; bh=pG3526ZPCUPh5sIxvP+Stjw+WCU761KQjmTsvai6FW8=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Qtzd4Ke/4vGR/yBZ0YzpT2V06N7riP9ey2eJRilNYquunTa1CQgKL9Q0q9Iije+I0 QRJQhebc+xWvhCAvDut/z5CdIIfqtvDYXL+zFT5VT+Asge17uZLus09Cuwo+pGAiah XQkGq/ZnfH4XZKW97TICjZyGuVOqn5N8Y12wDvN8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B8A8EF80253; Mon, 12 Jul 2021 13:11:59 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 92C18F80083; Mon, 12 Jul 2021 13:11:57 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 38C7FF80083 for ; Mon, 12 Jul 2021 13:11:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 38C7FF80083 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="k301d9Ek"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="O73yPhVt" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 19D242215B; Mon, 12 Jul 2021 11:11:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1626088312; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wGyjZ54sfARrkTiF9gq//0yu31/Cfo3jARX6yFoGgcQ=; b=k301d9EkspvvpafGnh7pPkzoDza/hXcMvpPrPYmV3nC8nfvud+zNbNMeE9rCAHc5/V1upF /CnwV4wPNrGf606hrMgW3ibNmrpwhVg0kGLMR5lhcX7z2oW+rg+xAatnCJET/v1Wvqxvlk 3tiCfPvYjFHU6WjfRr6cQnC9CASDXtM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1626088312; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wGyjZ54sfARrkTiF9gq//0yu31/Cfo3jARX6yFoGgcQ=; b=O73yPhVtf9xM92f3TdCArmX4zIHIc03l9riELuSvUGWb7cASXH6yg2WFAwJJYbL+q21dlG FIHCSSE6JZSiT+DQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 0CF09A3B87; Mon, 12 Jul 2021 11:11:52 +0000 (UTC) Date: Mon, 12 Jul 2021 13:11:52 +0200 Message-ID: From: Takashi Iwai To: Alan Young Subject: Re: [PATCH] ALSA: core: Call substream ack() method upon compat mmap, commit In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 12 Jul 2021 12:05:40 +0200, Alan Young wrote: > > If a 32-bit application is being used with a 64-bit kernel and is using > the mmap mechanism to write data, then the SNDRV_PCM_IOCTL_SYNC_PTR > ioctl results in calling snd_pcm_ioctl_sync_ptr_compat(). Make this use > pcm_lib_apply_appl_ptr() so that the substream's ack() method, if > defined, is called. > > The snd_pcm_sync_ptr() function, used in the 64-bit ioctl case, already > uses snd_pcm_ioctl_sync_ptr_compat(). > > > >From 9c3a4ffca82a0106cd858db8be29945cfbcc9952 Mon Sep 17 00:00:00 2001 > From: Alan Young > Date: Fri, 9 Jul 2021 09:48:54 +0100 > Subject: [PATCH] ALSA: core: Call substream ack() method upon compat mmap > commit > > If a 32-bit application is being used with a 64-bit kernel and is using > the mmap mechanism to write data, then the SNDRV_PCM_IOCTL_SYNC_PTR > ioctl results in calling snd_pcm_ioctl_sync_ptr_compat(). Make this use > pcm_lib_apply_appl_ptr() so that the substream's ack() method, if > defined, is called. > > The snd_pcm_sync_ptr() function, used in the 64-bit ioctl case, already > uses snd_pcm_ioctl_sync_ptr_compat(). > > Signed-off-by: Alan Young Thanks, applied. Takashi