Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 203CDC433E7 for ; Wed, 2 Sep 2020 17:34:02 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 885222083B for ; Wed, 2 Sep 2020 17:34:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="pJ6SgWP2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 885222083B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 032FC16C0; Wed, 2 Sep 2020 19:33:10 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 032FC16C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1599068040; bh=gIOJKKYC0y1pf0cQPJ8wWZn0Qi5B/twGLr+vW4NRqfw=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=pJ6SgWP2LrIcbdaeK1XF0D//RZtmm4GkGx7WGtcf+RlVSgYOXI4R4xAgVGrVYAw4y dus5RdVpIvRQF0Y6FMNH4cowcisVbjSe4bAwfWNwJ7lD75Zd8J3IbJSfLRdXyotvi0 uDO7w+UtATxgo0HS9GAZxC1DfWoXHu7rVsAqyfY4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6E665F802BC; Wed, 2 Sep 2020 19:32:36 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7BAE2F802C4; Wed, 2 Sep 2020 19:32:34 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id AB39FF802BC for ; Wed, 2 Sep 2020 19:32:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz AB39FF802BC X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6C9E1AFB2; Wed, 2 Sep 2020 17:32:29 +0000 (UTC) Date: Wed, 02 Sep 2020 19:32:28 +0200 Message-ID: From: Takashi Iwai To: Kai Vehmanen Subject: Re: [PATCH] ALSA: hda: add dev_dbg log when driver is not selected In-Reply-To: <20200902154239.1440537-1-kai.vehmanen@linux.intel.com> References: <20200902154239.1440537-1-kai.vehmanen@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Guennadi Liakhovetski , alsa-devel@alsa-project.org, Bard Liao , Pierre-Louis Bossart X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 02 Sep 2020 17:42:39 +0200, Kai Vehmanen wrote: > > From: Pierre-Louis Bossart > > On SKL+ Intel platforms, the driver selection is handled by the > snd_intel_dspcfg, and when the HDaudio legacy driver is not selected, > be it with the auto-selection or user preferences with a kernel > parameter, the probe aborts with no logs, only a -ENODEV return value. > > Having no dmesg trace, even with dynamic debug enabled, makes support > more complicated than it needs to be, and even experienced users can > be fooled. A simple dev_dbg() trace solves this problem. > > BugLink: https://github.com/thesofproject/linux/issues/2330 > Signed-off-by: Pierre-Louis Bossart > Reviewed-by: Bard Liao > Reviewed-by: Guennadi Liakhovetski > Signed-off-by: Kai Vehmanen Applied now. Thanks. Takashi