Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61447C47247 for ; Thu, 30 Apr 2020 16:45:57 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD01A2073E for ; Thu, 30 Apr 2020 16:45:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="aDhWV6jH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD01A2073E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 18A951665; Thu, 30 Apr 2020 18:45:05 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 18A951665 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1588265155; bh=D/JXfALShGVG9rLZOXaRNO4RMPCbQ/2qnUEk7v8pNo8=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=aDhWV6jHC2uJh1mw8vaI4BvK8PscVYuY+0jEpcJVDAck4065P85gWzbHpJg85NmBi Bc15sHHIOpFEuBe9vIpZ7zEHfFLolJBxdHfj3072ERjWvh00nXlKJkyzLHO9jygQSW NIEpMWqWFmgJMnlz1uWL2Y/U9TuH44Vd8HfGRBWg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 50FFBF80136; Thu, 30 Apr 2020 18:45:04 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C3E93F801DB; Thu, 30 Apr 2020 18:45:01 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 59A24F80123 for ; Thu, 30 Apr 2020 18:44:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 59A24F80123 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 598B7ABC7; Thu, 30 Apr 2020 16:44:53 +0000 (UTC) Date: Thu, 30 Apr 2020 18:44:53 +0200 Message-ID: From: Takashi Iwai To: Serge Belyshev Subject: Re: [PATCH] ALSA: pcm: oss: Avoid plugin buffer overflow In-Reply-To: <87v9lhkk5h.fsf@depni.sinp.msu.ru> References: <20200309082148.19855-1-tiwai@suse.de> <87v9lhkk5h.fsf@depni.sinp.msu.ru> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 30 Apr 2020 18:34:02 +0200, Serge Belyshev wrote: > > > ... > > > > This patch addresses those possible buffer overflow accesses by simply > > setting the upper limit per the given buffer size for each plugin > > before src_frames() and after dst_frames() calls. > > Hi! > > This patch breaks any output via oss interface, as evident by "mpv > --ao=oss somefile.mp3" or "mpg123 -o oss somefile.mp3" or just "cat > /dev/urandom > /dev/dsp", which worked previously in kernel version 5.5 > but not any longer starting with 5.6. > > It appears here that plugin->buf_frames is zero which results in ENXIO > returned to userspace. The fix is already in sound git tree, and will be in the next pull request to 5.7-rc4. thanks, Takashi