Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE37BC432C0 for ; Tue, 3 Dec 2019 19:09:49 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54B22206DF for ; Tue, 3 Dec 2019 19:09:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="sHN5FJ4l" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54B22206DF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9BE6586F; Tue, 3 Dec 2019 20:08:57 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9BE6586F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1575400187; bh=bHlhZux0SWefpsiVPQFlHiWHSz2x98NslcLSE+GA3bA=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=sHN5FJ4llJB8Q03bA4CdSUEyjsqDnnuirhW0V9eH5jyli+CIKIZ4XIkGi3D9+v3Bw vzihSQFa2/11EdphxjdhXUDtHf241oiK4De7Bhg17TcU/Xtofg6v5J0lmVdDHjCy6/ W+KZyWLwQvQKNdjQDXI3chZceuUlIBWAhf4Qf81U= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 19400F800B4; Tue, 3 Dec 2019 20:08:57 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9A09BF80227; Tue, 3 Dec 2019 20:08:55 +0100 (CET) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B157CF800B4 for ; Tue, 3 Dec 2019 20:08:52 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B157CF800B4 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id CF2FAB2941; Tue, 3 Dec 2019 19:08:51 +0000 (UTC) Date: Tue, 03 Dec 2019 20:08:51 +0100 Message-ID: From: Takashi Iwai To: Pierre-Louis Bossart In-Reply-To: <4bd562e7-64f6-1852-fe64-d280e91569c3@linux.intel.com> References: <20191203161908.7496-1-perex@perex.cz> <4bd562e7-64f6-1852-fe64-d280e91569c3@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: ALSA development , Mark Brown Subject: Re: [alsa-devel] [PATCH] ASoC: snd-sof-pci - add model parameter and pass it to HDA codec driver X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 03 Dec 2019 19:57:30 +0100, Pierre-Louis Bossart wrote: > > > > On 12/3/19 10:19 AM, Jaroslav Kysela wrote: > > It may be useful to pass the specific model to the generic HDA codec > > routines like the legacy HDA driver (snd-hda-intel) allows. > > The model name "sofbus" is tricky anyway. > > Humm, I must admit I have never looked at this for the legacy driver, > and I am a bit confused on what this would be used for? > The legacy driver uses codec->modelname but I can't figure out this > part in hda_codec.c > > if (codec->bus->modelname) { > codec->modelname = kstrdup(codec->bus->modelname, GFP_KERNEL); > > In theory there can be multiple codecs per bus (with different SDIs) > so using the bus->modelname for the codec->modelname looks odd. That's true. However, basically the model name is specific to the whole device, hence it's usually OK to pass to all codecs. The mismatched model name is just ignored (that's why the current code with model="sofbus" works). So you can think it a kind of quirk lookup with a system name given explicitly by user. > Is there an example of this being used for my education? You can find the list in Documentation/sound/hd-audio/models.rst and the usage in Documentation/sound/hd-audio/notes.rst. The documents are a bit outdated, though. Takashi > Also it'd make more sense to me to have this parameter in an > intel-specific module, not the top level PCI one? > > > > > Signed-off-by: Jaroslav Kysela > > Cc: Pierre-Louis Bossart > > Cc: Mark Brown > > --- > > include/sound/sof.h | 1 + > > sound/soc/sof/intel/hda.c | 2 +- > > sound/soc/sof/sof-pci-dev.c | 5 +++++ > > 3 files changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/include/sound/sof.h b/include/sound/sof.h > > index 479101736ee0..a62686baa95d 100644 > > --- a/include/sound/sof.h > > +++ b/include/sound/sof.h > > @@ -25,6 +25,7 @@ struct snd_sof_pdata { > > const char *drv_name; > > const char *name; > > const char *platform; > > + const char *modelname; > > struct device *dev; > > diff --git a/sound/soc/sof/intel/hda.c b/sound/soc/sof/intel/hda.c > > index 91bd88fddac7..ccb640bacc99 100644 > > --- a/sound/soc/sof/intel/hda.c > > +++ b/sound/soc/sof/intel/hda.c > > @@ -271,7 +271,7 @@ static int hda_init(struct snd_sof_dev *sdev) > > mutex_init(&hbus->prepare_mutex); > > hbus->pci = pci; > > hbus->mixer_assigned = -1; > > - hbus->modelname = "sofbus"; > > + hbus->modelname = sdev->pdata->modelname; > > /* initialise hdac bus */ > > bus->addr = pci_resource_start(pci, 0); > > diff --git a/sound/soc/sof/sof-pci-dev.c b/sound/soc/sof/sof-pci-dev.c > > index bbeffd932de7..c01ad85aad2a 100644 > > --- a/sound/soc/sof/sof-pci-dev.c > > +++ b/sound/soc/sof/sof-pci-dev.c > > @@ -34,6 +34,10 @@ static int sof_pci_debug; > > module_param_named(sof_pci_debug, sof_pci_debug, int, 0444); > > MODULE_PARM_DESC(sof_pci_debug, "SOF PCI debug options (0x0 all off)"); > > +static char *model; > > +module_param(model, charp, 0444); > > +MODULE_PARM_DESC(model, "Use the given HDA board model."); > > + > > #define SOF_PCI_DISABLE_PM_RUNTIME BIT(0) > > #if IS_ENABLED(CONFIG_SND_SOC_SOF_APOLLOLAKE) > > @@ -326,6 +330,7 @@ static int sof_pci_probe(struct pci_dev *pci, > > sof_pdata->desc = (struct sof_dev_desc *)pci_id->driver_data; > > sof_pdata->dev = dev; > > sof_pdata->platform = dev_name(dev); > > + sof_pdata->modelname = model; > > /* alternate fw and tplg filenames ? */ > > if (fw_path) > > > _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel