From: Takashi Iwai Subject: Re: [PATCH] ALSA: hda/realtek - Add disable auto-mute quirk for HP Spectre x360 laptop Date: Wed, 21 Nov 2018 17:51:30 +0100 Message-ID: References: <1542809492-54931-1-git-send-email-gkumar@neverware.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <1542809492-54931-1-git-send-email-gkumar@neverware.com> Sender: linux-kernel-owner@vger.kernel.org To: Girija Kumar Kasinadhuni Cc: alsa-devel@alsa-project.org, Hui Wang , Jaroslav Kysela , KailangYang , linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Wed, 21 Nov 2018 15:11:31 +0100, Girija Kumar Kasinadhuni wrote: > > This device makes a loud buzzing sound when a headphone is inserted while > playing audio at full volume through the speaker. > > Signed-off-by: Girija Kumar Kasinadhuni The fixup entry you added won't "disable" but it switch to the auto-mute via amp instead of toggling pin control. Please correct the subject and the description, and resubmit. thanks, Takashi > --- > sound/pci/hda/patch_realtek.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index fa61674..eeff2ff 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -5495,6 +5495,7 @@ enum { > ALC255_FIXUP_DELL_HEADSET_MIC, > ALC295_FIXUP_HP_X360, > ALC221_FIXUP_HP_HEADSET_MIC, > + ALC295_FIXUP_HP_DISABLE_AUTOMUTE, > }; > > static const struct hda_fixup alc269_fixups[] = { > @@ -6362,6 +6363,10 @@ static const struct hda_fixup alc269_fixups[] = { > .chained = true, > .chain_id = ALC269_FIXUP_HEADSET_MIC > }, > + [ALC295_FIXUP_HP_DISABLE_AUTOMUTE] = { > + .type = HDA_FIXUP_FUNC, > + .v.func = alc_fixup_auto_mute_via_amp, > + }, > }; > > static const struct snd_pci_quirk alc269_fixup_tbl[] = { > @@ -6486,6 +6491,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x103c, 0x82bf, "HP", ALC221_FIXUP_HP_MIC_NO_PRESENCE), > SND_PCI_QUIRK(0x103c, 0x82c0, "HP", ALC221_FIXUP_HP_MIC_NO_PRESENCE), > SND_PCI_QUIRK(0x103c, 0x83b9, "HP Spectre x360", ALC269_FIXUP_HP_MUTE_LED_MIC3), > + SND_PCI_QUIRK(0x103c, 0x83b9, "HP Spectre X360 ", ALC295_FIXUP_HP_DISABLE_AUTOMUTE), > SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC), > SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300), > SND_PCI_QUIRK(0x1043, 0x106d, "Asus K53BE", ALC269_FIXUP_LIMIT_INT_MIC_BOOST), > -- > 2.7.4 >