From: Takashi Iwai Subject: Re: [PATCH] ASoC: intel: Don't print FW version repeatedly Date: Mon, 27 Mar 2017 14:10:37 +0200 Message-ID: References: <20170327083958.18020-1-tiwai@suse.de> <20170327100658.GI9308@localhost> <20170327101354.fgvu2s6ewdccha67@sirena.org.uk> <20170327103712.GO9308@localhost> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 7A37926583C for ; Mon, 27 Mar 2017 14:10:38 +0200 (CEST) In-Reply-To: <20170327103712.GO9308@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Vinod Koul Cc: Liam Girdwood , alsa-devel@alsa-project.org, Mark Brown , Pierre-Louis Bossart List-Id: alsa-devel@alsa-project.org On Mon, 27 Mar 2017 12:37:12 +0200, Vinod Koul wrote: > > On Mon, Mar 27, 2017 at 12:24:20PM +0200, Takashi Iwai wrote: > > On Mon, 27 Mar 2017 12:13:54 +0200, > > Mark Brown wrote: > > > > > > On Mon, Mar 27, 2017 at 03:36:58PM +0530, Vinod Koul wrote: > > > > On Mon, Mar 27, 2017 at 10:39:58AM +0200, Takashi Iwai wrote: > > > > > > > > - dev_info(sst_drv_ctx->dev, "FW Version %02x.%02x.%02x.%02x\n", > > > > > + if (memcmp(&sst_drv_ctx->fw_version, &init->fw_version, > > > > > + sizeof(init->fw_version))) > > > > > > > wont dev_info_once be better here? We are really not expecting a new version > > > > after suspend :) > > > > > > You are if someone upgrades their userspace. > > > > Right. If we want to keep the old one consistently, you should cache > > the firmware instead of doing request_firmware at each time. > > Ah great thanks for reminding, we actually do that, so we don't load from > userspace all the time. That was done to get good latency and avoid 50ms ish > time it used to load the firmware. > > see sst_cache_and_parse_fw() so dev_info_once() would suffice here OK, I'll respin the patch with it. thanks, Takashi