From: Takashi Iwai Subject: Re: [PATCH 3/6] alsa-lib: pcm:dshare enable silence Date: Mon, 02 Jan 2017 14:55:45 +0100 Message-ID: References: <1483079351-28905-1-git-send-email-sutar.mounesh@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 8BCD0266652 for ; Mon, 2 Jan 2017 14:55:46 +0100 (CET) In-Reply-To: <1483079351-28905-1-git-send-email-sutar.mounesh@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: sutar.mounesh@gmail.com Cc: alsa-devel@alsa-project.org, Alexander Jahn , Andreas Pape , mounesh_sutar@mentor.com List-Id: alsa-devel@alsa-project.org On Fri, 30 Dec 2016 07:29:11 +0100, sutar.mounesh@gmail.com wrote: > > From: Alexander Jahn > > This issue depends on system load - if the process using dshare is scheduled > fast enough, then there is no noise. A delay of e.g >~2ms produces hearable noise. > > Reproduction with instrumented aplay(sleep every 100th period for a given time): > During the sleep time of 2000000us (2s) the hardware plays old samples in a > loop before xrun is detected and recovered after the sleep. > This is resolved by placing it in silence, in case of dshare plugin. > > Signed-off-by: Alexander Jahn > Signed-off-by: Andreas Pape Applied this one with a slight coding style fix. Thanks. Takashi > > diff --git a/src/pcm/pcm_direct.c b/src/pcm/pcm_direct.c > index 4234d66..779845c 100644 > --- a/src/pcm/pcm_direct.c > +++ b/src/pcm/pcm_direct.c > @@ -1240,7 +1240,7 @@ int snd_pcm_direct_initialize_slave(snd_pcm_direct_t *dmix, snd_pcm_t *spcm, str > return ret; > } > > - if (dmix->type != SND_PCM_TYPE_DMIX) > + if ((dmix->type != SND_PCM_TYPE_DMIX)&&(dmix->type != SND_PCM_TYPE_DSHARE)) > goto __skip_silencing; > > ret = snd_pcm_sw_params_set_silence_threshold(spcm, &sw_params, 0); > -- > 1.7.9.5 >