From: Takashi Iwai Subject: Re: [PATCH] fm801: move to pcim_* and devm_* functions Date: Wed, 07 Jan 2015 14:12:20 +0100 Message-ID: References: <1420587617-28521-1-git-send-email-andy.shevchenko@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 3F0562604CA for ; Wed, 7 Jan 2015 14:12:22 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Andy Shevchenko Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org QXQgV2VkLCA3IEphbiAyMDE1IDE0OjIwOjI2ICswMjAwLApBbmR5IFNoZXZjaGVua28gd3JvdGU6 Cj4gCj4gT24gV2VkLCBKYW4gNywgMjAxNSBhdCAxOjI3IFBNLCBUYWthc2hpIEl3YWkgPHRpd2Fp QHN1c2UuZGU+IHdyb3RlOgo+ID4gQXQgV2VkLCA3IEphbiAyMDE1IDEyOjU0OjQwICswMjAwLAo+ ID4gQW5keSBTaGV2Y2hlbmtvIHdyb3RlOgo+ID4+Cj4gPj4gT24gV2VkLCBKYW4gNywgMjAxNSBh dCA5OjExIEFNLCBUYWthc2hpIEl3YWkgPHRpd2FpQHN1c2UuZGU+IHdyb3RlOgo+ID4+ID4gQXQg V2VkLCAgNyBKYW4gMjAxNSAwMTo0MDoxNyArMDIwMCwKPiA+PiA+IEFuZHkgU2hldmNoZW5rbyB3 cm90ZToKPiA+PiA+Pgo+ID4+ID4+IFRoZSBtYW5hZ2VkIGZ1bmN0aW9ucyBhbGxvdyB0byBnZXQg LT5wcm9iZSgpIGFuZCAtPnJlbW92ZSgpIHNpbXBsaWVyLgo+ID4+ID4+IFRoaXMgcGF0Y2ggY29u dmVydHMgY29kZSB0byB1c2UgbWFuYWdlZCBmdW5jdGlvbnMuCj4gPj4gPgo+ID4+ID4gVGhpcyBk b2Vzbid0IHdvcmsgd2VsbCBiZWNhdXNlIG9mIHRoZSBvcmRlciBvZiByZWxlYXNlIGNhbGxzIGlu Cj4gPj4gPiBkZXZpY2VfcmVsZWFzZSgpLiAgZGV2cmVzX3JlbGVhc2VfYWxsKCkgaXMgY2FsbGVk IGF0IGZpcnN0IGJlZm9yZQo+ID4+ID4gYW55dGhpbmcgZWxzZS4gIFRodXMgdGhlIGNhcmQncyBm cmVlIGNhbGxiYWNrIHdvdWxkIGJlIGNhbGxlZCBhZnRlcgo+ID4+ID4gaXQsIGFuZCBzbmRfZm04 MDFfZnJlZSgpIHRvdWNoZXMgdGhlIGhhcmR3YXJlIGJlZm9yZSBkaXNhYmxpbmcuCj4gPj4gPgo+ ID4+Cj4gPj4gSG1t4oCmIEkgZGlkbid0IGdldCB3aGF0IG1ha2UgdGhvc2UgY2FsbHMuIFNvdW5k IGNvcmU/IFRoZSBkcml2ZXIgaXMgYQo+ID4+IG5vcm1hbCBQQ0kgZHJpdmVyLCBzbyByZXNvdXJj ZXMgd2lsbCBiZSBmcmVlZCAqYWZ0ZXIqIC0+cmVtb3ZlKCkgb2YKPiA+PiBkcml2ZXIgd2FzIGNh bGxlZC4KPiA+PiBQbGVhc2UsIGVsYWJvcmF0ZS4KPiA+Cj4gPiBBaCwgT0ssIHRoaXMgc2VlbXMg d29ya2luZywgYXMgdGhpcyBpcyB0aGUgbWFuYWdlZCAqcGNpKiBkZXZpY2UgdGhhdAo+ID4gaXMg YSBwYXJlbnQgb2YgdGhlIGNhcmQgZGV2aWNlLCB0aHVzIGl0IHNoYWxsIGJlIHJlbGVhc2VkIGFm dGVyIHRoZQo+ID4gY2hpbGRyZW4uCj4gPgo+ID4gQnV0IGFueSByZWFzb24gbm90IHRvIHVzZSBw Y2ltX2lvbWFwX3JlZ2lvbnNfcmVxdWVzdF9hbGwoKT8KPiAKPiBZZXMuIEkgd2FzIGRvdWJ0IHRv IHB1dCBhIGNvbW1lbnQgYWJvdXQgdGhpcy4KCldlbGwsIHBjaW1faW9tYXBfcmVnaW9uc19yZXF1 ZXN0X2FsbCgpIGNhbiBqdXN0IHJlcXVlc3QgcmVnaW9ucwp3aXRob3V0IGFjdHVhbGx5IGlvbWFw cGluZyB2aWEgcGFzc2luZyAwIHRvIG1hc2suICBCdXQsIG5vdyBsb29raW5nIGF0CnRoZSBjb2Rl IGFnYWluLCBJIGNvdWxkbid0IGZpbmQgdGhlIHBsYWNlIHJlbGVhc2luZyB0aGUgbm9uLW1taW8K cmVnaW9ucy4gIEhtbS4uLiBpdCBtaWdodCBiZSBhIGxlYWs/Cgo+IFNvLCB0aGUgaW5pdGlhbCBp ZGVhIGlzCj4gdG8gbW92ZSB0byBNTUlPIGluc3RlYWQgb2YgSU8gYWNjZXNzLiBUaGF0J3Mgd2h5 IHlvdSBtYXkgc2VlIHByZXZpb3VzCj4gcGF0Y2ggYWJvdXQgZm04MDFfe3JlYWQsd3JpdGV9dygp IG1hY3Jvcy4KPiBJIHdvdWxkIGxpa2UgdG8gZG8gdGhhdCBsYXRlci4KClllYWgsIG9mIGNvdXJz ZSwgcmV3cml0aW5nIHRvIE1NSU8gd291bGQgYmUgbmljZXIuICBJIGd1ZXNzIHlvdSdyZQp0ZXN0 aW5nIHdpdGggdGhlIHJlYWwgaGFyZHdhcmUsIHNvIEknbSBmb3IgdGhpcyByZXdyaXRlLgoKCnRo YW5rcywKClRha2FzaGkKCj4gCj4gPgo+ID4KPiA+IHRoYW5rcywKPiA+Cj4gPiBUYWthc2hpCj4g Pgo+ID4+Cj4gPj4gPgo+ID4+ID4gVGFrYXNoaQo+ID4+ID4KPiA+PiA+PiBXaGlsZSBoZXJlIHJl bW92ZSB0aGUgZGVhZCBjb2RlIGFuZCBmaXggdGhlIHZhbHVlIHByaW50ZWQgaW4gZXJyb3IKPiA+ PiA+PiBtZXNzYWdlLgo+ID4+ID4+Cj4gPj4gPj4gU2lnbmVkLW9mZi1ieTogQW5keSBTaGV2Y2hl bmtvIDxhbmR5LnNoZXZjaGVua29AZ21haWwuY29tPgo+ID4+ID4+IC0tLQo+ID4+ID4+ICBzb3Vu ZC9wY2kvZm04MDEuYyB8IDI5ICsrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gPj4gPj4g IDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDIyIGRlbGV0aW9ucygtKQo+ID4+ID4+ Cj4gPj4gPj4gZGlmZiAtLWdpdCBhL3NvdW5kL3BjaS9mbTgwMS5jIGIvc291bmQvcGNpL2ZtODAx LmMKPiA+PiA+PiBpbmRleCBkY2RhM2MxLi4yNzA4NTAwIDEwMDY0NAo+ID4+ID4+IC0tLSBhL3Nv dW5kL3BjaS9mbTgwMS5jCj4gPj4gPj4gKysrIGIvc291bmQvcGNpL2ZtODAxLmMKPiA+PiA+PiBA QCAtMTE3OCwxMiArMTE3OCw4IEBAIHN0YXRpYyBpbnQgc25kX2ZtODAxX2ZyZWUoc3RydWN0IGZt ODAxICpjaGlwKQo+ID4+ID4+ICAgICAgICAgICAgICAgdjRsMl9kZXZpY2VfdW5yZWdpc3Rlcigm Y2hpcC0+djRsMl9kZXYpOwo+ID4+ID4+ICAgICAgIH0KPiA+PiA+PiAgI2VuZGlmCj4gPj4gPj4g LSAgICAgaWYgKGNoaXAtPmlycSA+PSAwKQo+ID4+ID4+IC0gICAgICAgICAgICAgZnJlZV9pcnEo Y2hpcC0+aXJxLCBjaGlwKTsKPiA+PiA+PiAgICAgICBwY2lfcmVsZWFzZV9yZWdpb25zKGNoaXAt PnBjaSk7Cj4gPj4gPj4gLSAgICAgcGNpX2Rpc2FibGVfZGV2aWNlKGNoaXAtPnBjaSk7Cj4gPj4g Pj4KPiA+PiA+PiAtICAgICBrZnJlZShjaGlwKTsKPiA+PiA+PiAgICAgICByZXR1cm4gMDsKPiA+ PiA+PiAgfQo+ID4+ID4+Cj4gPj4gPj4gQEAgLTEyMDYsMjggKzEyMDIsMjMgQEAgc3RhdGljIGlu dCBzbmRfZm04MDFfY3JlYXRlKHN0cnVjdCBzbmRfY2FyZCAqY2FyZCwKPiA+PiA+PiAgICAgICB9 Owo+ID4+ID4+Cj4gPj4gPj4gICAgICAgKnJjaGlwID0gTlVMTDsKPiA+PiA+PiAtICAgICBpZiAo KGVyciA9IHBjaV9lbmFibGVfZGV2aWNlKHBjaSkpIDwgMCkKPiA+PiA+PiArICAgICBpZiAoKGVy ciA9IHBjaW1fZW5hYmxlX2RldmljZShwY2kpKSA8IDApCj4gPj4gPj4gICAgICAgICAgICAgICBy ZXR1cm4gZXJyOwo+ID4+ID4+IC0gICAgIGNoaXAgPSBremFsbG9jKHNpemVvZigqY2hpcCksIEdG UF9LRVJORUwpOwo+ID4+ID4+IC0gICAgIGlmIChjaGlwID09IE5VTEwpIHsKPiA+PiA+PiAtICAg ICAgICAgICAgIHBjaV9kaXNhYmxlX2RldmljZShwY2kpOwo+ID4+ID4+ICsgICAgIGNoaXAgPSBk ZXZtX2t6YWxsb2MoJnBjaS0+ZGV2LCBzaXplb2YoKmNoaXApLCBHRlBfS0VSTkVMKTsKPiA+PiA+ PiArICAgICBpZiAoY2hpcCA9PSBOVUxMKQo+ID4+ID4+ICAgICAgICAgICAgICAgcmV0dXJuIC1F Tk9NRU07Cj4gPj4gPj4gLSAgICAgfQo+ID4+ID4+ICAgICAgIHNwaW5fbG9ja19pbml0KCZjaGlw LT5yZWdfbG9jayk7Cj4gPj4gPj4gICAgICAgY2hpcC0+Y2FyZCA9IGNhcmQ7Cj4gPj4gPj4gICAg ICAgY2hpcC0+cGNpID0gcGNpOwo+ID4+ID4+ICAgICAgIGNoaXAtPmlycSA9IC0xOwo+ID4+ID4+ ICAgICAgIGNoaXAtPnRlYTU3NXhfdHVuZXIgPSB0ZWE1NzV4X3R1bmVyOwo+ID4+ID4+IC0gICAg IGlmICgoZXJyID0gcGNpX3JlcXVlc3RfcmVnaW9ucyhwY2ksICJGTTgwMSIpKSA8IDApIHsKPiA+ PiA+PiAtICAgICAgICAgICAgIGtmcmVlKGNoaXApOwo+ID4+ID4+IC0gICAgICAgICAgICAgcGNp X2Rpc2FibGVfZGV2aWNlKHBjaSk7Cj4gPj4gPj4gKyAgICAgaWYgKChlcnIgPSBwY2lfcmVxdWVz dF9yZWdpb25zKHBjaSwgIkZNODAxIikpIDwgMCkKPiA+PiA+PiAgICAgICAgICAgICAgIHJldHVy biBlcnI7Cj4gPj4gPj4gLSAgICAgfQo+ID4+ID4+ICAgICAgIGNoaXAtPnBvcnQgPSBwY2lfcmVz b3VyY2Vfc3RhcnQocGNpLCAwKTsKPiA+PiA+PiAgICAgICBpZiAoKHRlYTU3NXhfdHVuZXIgJiBU VU5FUl9PTkxZKSA9PSAwKSB7Cj4gPj4gPj4gLSAgICAgICAgICAgICBpZiAocmVxdWVzdF9pcnEo cGNpLT5pcnEsIHNuZF9mbTgwMV9pbnRlcnJ1cHQsIElSUUZfU0hBUkVELAo+ID4+ID4+IC0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgIEtCVUlMRF9NT0ROQU1FLCBjaGlwKSkgewo+ID4+ID4+ IC0gICAgICAgICAgICAgICAgICAgICBkZXZfZXJyKGNhcmQtPmRldiwgInVuYWJsZSB0byBncmFi IElSUSAlZFxuIiwgY2hpcC0+aXJxKTsKPiA+PiA+PiArICAgICAgICAgICAgIGlmIChkZXZtX3Jl cXVlc3RfaXJxKCZwY2ktPmRldiwgcGNpLT5pcnEsIHNuZF9mbTgwMV9pbnRlcnJ1cHQsCj4gPj4g Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSVJRRl9TSEFSRUQsIEtCVUlMRF9NT0RO QU1FLCBjaGlwKSkgewo+ID4+ID4+ICsgICAgICAgICAgICAgICAgICAgICBkZXZfZXJyKGNhcmQt PmRldiwgInVuYWJsZSB0byBncmFiIElSUSAlZFxuIiwgcGNpLT5pcnEpOwo+ID4+ID4+ICAgICAg ICAgICAgICAgICAgICAgICBzbmRfZm04MDFfZnJlZShjaGlwKTsKPiA+PiA+PiAgICAgICAgICAg ICAgICAgICAgICAgcmV0dXJuIC1FQlVTWTsKPiA+PiA+PiAgICAgICAgICAgICAgIH0KPiA+PiA+ PiBAQCAtMTI0MiwxMiArMTIzMyw2IEBAIHN0YXRpYyBpbnQgc25kX2ZtODAxX2NyZWF0ZShzdHJ1 Y3Qgc25kX2NhcmQgKmNhcmQsCj4gPj4gPj4gICAgICAgLyogaW5pdCBtaWdodCBzZXQgdHVuZXIg YWNjZXNzIG1ldGhvZCAqLwo+ID4+ID4+ICAgICAgIHRlYTU3NXhfdHVuZXIgPSBjaGlwLT50ZWE1 NzV4X3R1bmVyOwo+ID4+ID4+Cj4gPj4gPj4gLSAgICAgaWYgKGNoaXAtPmlycSA+PSAwICYmICh0 ZWE1NzV4X3R1bmVyICYgVFVORVJfT05MWSkpIHsKPiA+PiA+PiAtICAgICAgICAgICAgIHBjaV9j bGVhcl9tYXN0ZXIocGNpKTsKPiA+PiA+PiAtICAgICAgICAgICAgIGZyZWVfaXJxKGNoaXAtPmly cSwgY2hpcCk7Cj4gPj4gPj4gLSAgICAgICAgICAgICBjaGlwLT5pcnEgPSAtMTsKPiA+PiA+PiAt ICAgICB9Cj4gPj4gPj4gLQo+ID4+ID4+ICAgICAgIGlmICgoZXJyID0gc25kX2RldmljZV9uZXco Y2FyZCwgU05EUlZfREVWX0xPV0xFVkVMLCBjaGlwLCAmb3BzKSkgPCAwKSB7Cj4gPj4gPj4gICAg ICAgICAgICAgICBzbmRfZm04MDFfZnJlZShjaGlwKTsKPiA+PiA+PiAgICAgICAgICAgICAgIHJl dHVybiBlcnI7Cj4gPj4gPj4gLS0KPiA+PiA+PiAxLjguMy4xMDEuZzcyN2E0NmIKPiA+PiA+Pgo+ ID4+Cj4gPj4KPiA+Pgo+ID4+IC0tCj4gPj4gV2l0aCBCZXN0IFJlZ2FyZHMsCj4gPj4gQW5keSBT aGV2Y2hlbmtvCj4gPj4KPiAKPiAKPiAKPiAtLSAKPiBXaXRoIEJlc3QgUmVnYXJkcywKPiBBbmR5 IFNoZXZjaGVua28KPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KQWxzYS1kZXZlbCBtYWlsaW5nIGxpc3QKQWxzYS1kZXZlbEBhbHNhLXByb2plY3Qub3Jn Cmh0dHA6Ly9tYWlsbWFuLmFsc2EtcHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbHNhLWRl dmVsCg==