From: Takashi Iwai Subject: Re: [FT C400, PATCH RFC, v4 00/10] M-Audio Fast Track C400 Date: Thu, 29 Nov 2012 08:53:54 +0100 Message-ID: References: <1354143341-1623-1-git-send-email-eldad@fogrefinery.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id B88CB265076 for ; Thu, 29 Nov 2012 08:53:55 +0100 (CET) In-Reply-To: <1354143341-1623-1-git-send-email-eldad@fogrefinery.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Eldad Zack Cc: Grant Diffey , Chris Cavey , Clemens Ladisch , alsa-devel@alsa-project.org, Felix Homann , George Willian Condomitti , Daniel Mack List-Id: alsa-devel@alsa-project.org At Wed, 28 Nov 2012 23:55:31 +0100, Eldad Zack wrote: > > Hi, > > The following patches adds support for the M-Audio Fast Track C400. > This is version 4 of the patch series. > > * Incoroprated the feedback from Clemens Ladisch : > Moved the quirks structure to the right place (also in other places, though > not strictly required) and removed the "set quirks" log messages. > Thanks, Clemens! > > * Added a patch to address the regression introduced by commit > 947d299686aa9cc8aecf749d54e8475c6e498956 , "ALSA: snd-usb: properly initialize > the sync endpoint". I believe there are no other devices that affected by this > issue. Opening only the playback stream without first opening the capture > stream now works with the C400. Thanks. I applied all patches except for the new one (2/10 usb-audio: correct sync ep init). This patch needs a bit more care, as it seems. I know it must be fixed for FT C400 but the fix itself is independent from others, so I merged others first to the rest work easier. (snip) > * To deal with the mixer channel IDs, limited by cmask bit length, > I introduced an offset value. This allows to get rid of the shorehorning > of the IDs into cmask and device-referencing in the low-level functions. > Is this a good approach? Looks good enough to me. It has a minimum impact, so safe to apply. Takashi