From: Takashi Iwai Subject: Re: [PATCH 08/10] ALSA: hda - Add support for Line-Out automute to Realtek auto-parser Date: Sat, 30 Apr 2011 12:23:03 +0200 Message-ID: References: <1304097516-7258-1-git-send-email-tiwai@suse.de> <1304097516-7258-9-git-send-email-tiwai@suse.de> <4DBBB1CA.8020508@canonical.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (cantor.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id 94F4B103811 for ; Sat, 30 Apr 2011 12:23:06 +0200 (CEST) In-Reply-To: <4DBBB1CA.8020508@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: David Henningsson Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Sat, 30 Apr 2011 08:52:58 +0200, David Henningsson wrote: > > On 2011-04-29 19:18, Takashi Iwai wrote: > > By popular demands, I add the functionality to mute / unmute the > > line-out jacks per the headphone plug / unplug. For achieving this > > and keeping the compatibility with the old behavior, the new mixer > > enum "Auto-Mute Mode" is added. With this, user can control the > > auto-mute behavior either disabled, speaker-only or lineout+speaker. > > Hi Takashi, > > Great to see these improvements! I have a question about this patch: > > There are three ways we can auto-mute: > > Headphones might mute Internal Speakers. > Headphones might mute Line out. > Line out might mute Internal Speakers. > > Are we considering the third option here or is that still unsupported? Yes, it'll behave so. Now we have "Auto-Mute Mode" enum control, and it provides "Disable", "Speaker only" and "Line-Out+Speaker" choice in the case of LO+HP+SPK case. When only HP+LO, LO+SPK or HP+SPK are present, this enum gives only "Disable" and "Enable" choice. > Also, it might be slightly confusing for the end-user to have options > that are irrelevant, e g if there are no internal speakers (or line-out > for that matter), that option will still show up. Right? If there is only one output type, this enum won't appear. I guess this should cover most of use-cases, and flexible enough for covering both old and new behavior. thanks, Takashi