From: Takashi Iwai Subject: Re: [PATCH 1/2 v4] ALSA: Add snd_ctl_replace() to dynamically replace a control Date: Tue, 22 Mar 2011 16:49:35 +0100 Message-ID: References: <1300277800-610-1-git-send-email-dp@opensource.wolfsonmicro.com> <20110322153507.GA7848@opensource.wolfsonmicro.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 8E90F24416 for ; Tue, 22 Mar 2011 16:49:38 +0100 (CET) In-Reply-To: <20110322153507.GA7848@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Dimitris Papastamos Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, Mark Brown , Clemens Ladisch , lrg@ti.com, lrg@slimlogic.co.uk List-Id: alsa-devel@alsa-project.org At Tue, 22 Mar 2011 15:35:07 +0000, Dimitris Papastamos wrote: > > On Tue, Mar 22, 2011 at 04:17:51PM +0100, Takashi Iwai wrote: > > At Wed, 16 Mar 2011 12:16:39 +0000, > > Dimitris Papastamos wrote: > > > > > > Add a function to dynamically replace a given control. If the > > > control does not already exist, a third parameter is used to determine > > > whether to actually add that control. This is useful in cases where > > > downloadable firmware at runtime can add or replace existing controls. > > > A separate patch needs to be made to allow ALSA Mixer to render the > > > replaced controls on the fly. > > > > > > Signed-off-by: Dimitris Papastamos > > > > Now I applied this one to topic/misc branch with slight coding-style > > fixes checkpatch complained. But I didn't apply the patch for ASoC. > > Hi, > > The reason why I did not fix those was because I tried to match the > style of sound/core/control.c. Yeah, it could be easily guessed. Takashi