From: Takashi Iwai Subject: Re: [PATCH 1/1] hdsp: allow firmware loading from inside the kernel Date: Tue, 12 May 2009 09:36:23 +0200 Message-ID: References: <4A091428.2000106@free.fr> <4A091B81.3050107@free.fr> <4A091FAF.9090400@free.fr> <4A092467.1070007@free.fr> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mx1.suse.de (cantor.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id 27B2810382F for ; Tue, 12 May 2009 09:36:24 +0200 (CEST) In-Reply-To: <4A092467.1070007@free.fr> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: =?ISO-8859-1?Q?Rapha=EBl?= Doursenaud Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Tue, 12 May 2009 09:25:27 +0200, Rapha=EBl Doursenaud wrote: > = > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > = > Takashi Iwai a =E9crit : > > At Tue, 12 May 2009 09:05:19 +0200, > > Rapha=EBl Doursenaud wrote: > >> -----BEGIN PGP SIGNED MESSAGE----- > >> Hash: SHA1 > >> > >> Takashi Iwai a =E9crit : > >>> At Tue, 12 May 2009 08:47:29 +0200, > >>> Rapha=EBl Doursenaud wrote: > >>>> -----BEGIN PGP SIGNED MESSAGE----- > >>>> Hash: SHA1 > >>>> > >>>> Takashi Iwai a =E9crit : > >>>>> At Tue, 12 May 2009 08:16:08 +0200, > >>>>> Rapha=EBl Doursenaud wrote: > >>>>>> From: Rapha=EBl Doursenaud > >>>>>> > >>>>>> Allow the use of the FIRMWARE_IN_KERNEL option with hdsp cards and > >>>>>> in-kernel driver. > >>>>> Did it really work without problems? > >>>>> > >>>>> > >>>>> Takashi > >>>> Tested over the weekend with two multifaces in my DAW. > >>>> Got no problem. > >>> Interesting. > >>> Did you build the firmware file into the kernel, or not? > >>> > >>> > >>> Takashi > >> Yes I built all hdsp fimware files (multiface_firmware.bin > >> multiface_firmware_rev11.bin digiface_firmware.bin > >> digiface_firmware_rev11.bin) into the kernel. > >> It's the aim of this patch. > > = > > Well, the problem I'm concerned is that the driver can be compiled > > in even if you have no built-in firmware. And there is no restriction > > or dependency check in Kconfig, so far. > > = > > Could you test how the kernel behaves without the built-in firmware? > > Does it hang or give any critical error? > > = > > = > > thanks, > > = > > Takashi > Could you be more specific? > I'm not sure to understand why it could be a problem. > Do you think that if I set FIRMWARE_IN_KERNEL without compiling the > firmware(s) in-kernel the request_firmware() will not resolve and cause > an error? Yes, exactly. request_firmware() shall fail in that case likely after a long time-out (unless you have the firmware files in initrd) because there is really no file / data available at the time it's called. And I'm not sure whether this could lead to a fatal operation error. Takashi