Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D2D1C433DF for ; Wed, 26 Aug 2020 18:53:21 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CBA03207BC for ; Wed, 26 Aug 2020 18:53:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="JM/ARAWp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBA03207BC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6DDAF16C9; Wed, 26 Aug 2020 20:52:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6DDAF16C9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1598467999; bh=KatLp4PuiE626eZD+9vMfHbkcy/j3in6hl6kjc5U9Es=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JM/ARAWpukDeCumMN6urYVJPtVuTUPlafhpPdwDCz+nLvDfkaU0hwswvmKlAJ//Ft 4QBSz3sLdTinACbVdctjALb/PXo9I+nICHMVjAq7pjLCwCzHlAga05SmN0kw+DK8dy BtgqGCpOwfjwBoYrDYhfGw4NsuohgLypLF+cg9IA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 15EC5F802A0; Wed, 26 Aug 2020 20:52:16 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 67665F802BC; Wed, 26 Aug 2020 20:52:15 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 37589F802A0 for ; Wed, 26 Aug 2020 20:52:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 37589F802A0 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2E3FEAF2C; Wed, 26 Aug 2020 18:52:38 +0000 (UTC) Date: Wed, 26 Aug 2020 20:52:06 +0200 Message-ID: From: Takashi Iwai To: Kai Vehmanen Subject: Re: [PATCH] ALSA: hda/hdmi: always check pin power status in i915 pin fixup In-Reply-To: <20200826170306.701566-1-kai.vehmanen@linux.intel.com> References: <20200826170306.701566-1-kai.vehmanen@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 26 Aug 2020 19:03:06 +0200, Kai Vehmanen wrote: > > When system is suspended with active audio playback to HDMI/DP, two > alternative sequences can happen at resume: > a) monitor is detected first and ALSA prepare follows normal > stream setup sequence, or > b) ALSA prepare is called first, but monitor is not yet detected, > so PCM is restarted without a pin, > > In case of (b), on i915 systems, haswell_verify_D0() is not called at > resume and the pin power state may be incorrect. Result is lack of audio > after resume with no error reported back to user-space. > > Fix the problem by always verifying converter and pin state in the > i915_pin_cvt_fixup(). > > BugLink: https://github.com/thesofproject/linux/issues/2388 > Signed-off-by: Kai Vehmanen Applied with Cc to stable now. Thanks. Takashi