Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF3E6C433E6 for ; Tue, 21 Jul 2020 08:01:26 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3900820709 for ; Tue, 21 Jul 2020 08:01:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="kkI9LTG7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3900820709 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9600F1666; Tue, 21 Jul 2020 10:00:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9600F1666 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1595318484; bh=Won3NTlGt77WIjlx4IyDKMH0+xG6FBPWPIDPDtIhdYU=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=kkI9LTG7jh8m15lTfmbYRNuFZr/1wVxGx3zM90YKaxVPVbrg+1SwlrQDr2VKSdcVe vsK+0017oAD8K1O8ACEEZlVHf+sMvrgmWtlcgJ/Ec4R2ZHAPLzt2RX4tkQqURXR/CS i9bFcqWzlwyrkHJi0quuRiT+ufzii5gnNw9ujg6A= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3D878F80087; Tue, 21 Jul 2020 10:00:34 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0E688F8024A; Tue, 21 Jul 2020 10:00:33 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C45A4F80087 for ; Tue, 21 Jul 2020 10:00:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C45A4F80087 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8C9FCAFCD; Tue, 21 Jul 2020 08:00:36 +0000 (UTC) Date: Tue, 21 Jul 2020 10:00:29 +0200 Message-ID: From: Takashi Iwai To: =?UTF-8?B?UmVuw6k=?= Herman Subject: Re: [PATCH 1/3] snd-usb-6fire: Move DMA-buffer off of the stack In-Reply-To: <20200721064853.9516-2-rene.herman@gmail.com> References: <20200721064853.9516-1-rene.herman@gmail.com> <20200721064853.9516-2-rene.herman@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: alsa-devel@alsa-project.org, Torsten Schenk X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 21 Jul 2020 08:48:51 +0200, René Herman wrote: > > snd-usb-fire currently fails its firmware load with "transfer buffer not dma > capable". Move said buffer off of the stack. > > Signed-off-by: René Herman > --- > firmware.c | 95 ++++++++++++++++++++++++++---------------------------- > 1 file changed, 46 insertions(+), 49 deletions(-) > > diff --git a/firmware.c b/firmware.c > index 69137c1..502653a 100644 > --- a/firmware.c > +++ b/firmware.c > @@ -355,63 +355,60 @@ static int usb6fire_fw_check(struct usb_interface *intf, const u8 *version) > > int usb6fire_fw_init(struct usb_interface *intf) > { > - int i; > - int ret; > struct usb_device *device = interface_to_usbdev(intf); > + int ret, i; > + > /* buffer: 8 receiving bytes from device and > * sizeof(EP_W_MAX_PACKET_SIZE) bytes for non-const copy */ > - u8 buffer[12]; > + u8 *buffer = kmalloc(12, GFP_KERNEL); > + > + if (!buffer) > + return -ENOMEM; > > ret = usb6fire_fw_ezusb_read(device, 1, 0, buffer, 8); > if (ret < 0) { > dev_err(&intf->dev, > "unable to receive device firmware state.\n"); > - return ret; > - } > - if (buffer[0] != 0xeb || buffer[1] != 0xaa || buffer[2] != 0x55) { > - dev_err(&intf->dev, > - "unknown device firmware state received from device:"); > - for (i = 0; i < 8; i++) > - printk(KERN_CONT "%02x ", buffer[i]); > - printk(KERN_CONT "\n"); > - return -EIO; > - } Could you rather change return with goto out (with ret variable set)? In that way we can see what actually you changed more clearly. thanks, Takashi