Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D86F1C2BA19 for ; Tue, 14 Apr 2020 10:28:47 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55AF42076B for ; Tue, 14 Apr 2020 10:28:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="vB3wbhc8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55AF42076B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9F3ED168D; Tue, 14 Apr 2020 12:27:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9F3ED168D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1586860125; bh=o6lolCB+yHIlu1upDMQQYQj6bQ/5pNSLPBgHZZ7LRvo=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=vB3wbhc80o9gNDBXlBcd6rGcY8D517+RvgmdkhuPJafG/iBysm5x/wrs1CyLzc8rr TnEd8/pjvBjBxVY/28qMtY+BbMmiClPJtsegBNnCDtc8b6m7q6KP0NlRDqkOtxaRRt jl8PaD6L4kkCuUiRNE2vAhtetDCBFTXgrIUBAyus= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 318E1F80126; Tue, 14 Apr 2020 12:27:55 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 82A42F8013D; Tue, 14 Apr 2020 12:27:54 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 99845F800F5 for ; Tue, 14 Apr 2020 12:27:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 99845F800F5 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id EAA94AAFD; Tue, 14 Apr 2020 10:27:48 +0000 (UTC) Date: Tue, 14 Apr 2020 12:27:49 +0200 Message-ID: From: Takashi Iwai To: Hui Wang Subject: Re: [PATCH] ALSA: hda: enable the runtime_pm for non-vgaswitcheroo hda controllers In-Reply-To: <20200414101405.6992-1-hui.wang@canonical.com> References: <20200414101405.6992-1-hui.wang@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 14 Apr 2020 12:14:05 +0200, Hui Wang wrote: > > Before the pci_driver->probe() is called, the pci subsystem calls > runtime_forbib() and runtime_get_sync() on this pci dev, so only call > runtime_put_autosuspend() is not enough to enable the runtime_pm on > this device. > > For controllers with vgaswitcheroo feature, the pci/quirks.c will call > runtime_allow() for this dev, then the controllers could enter > rt_idle/suspend/resume, but for non-vgaswitcheroo controllers like > Intel hda controllers, the runtime_pm is not enabled even it calls > put_autosuspend(). Need to call runtime_allow() for those controllers > in the hda driver. > > Signed-off-by: Hui Wang Was this behavior changed from the earlier kernels? I thought this was left untouched because it's supposed to be set via udev rules or such. OTOH, enabling the runtime PM is almost mandatory for modern systems, and I'm fine to apply this kind of forcible enablement. thanks, Takashi > --- > sound/pci/hda/hda_intel.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > index 8519051a426e..779705bef88b 100644 > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -2356,6 +2356,8 @@ static int azx_probe_continue(struct azx *chip) > > if (azx_has_pm_runtime(chip)) { > pm_runtime_use_autosuspend(&pci->dev); > + if (!use_vga_switcheroo(chip)) > + pm_runtime_allow(&pci->dev); > pm_runtime_put_autosuspend(&pci->dev); > } > > -- > 2.17.1 >