From: Takashi Iwai Subject: Re: [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files Date: Wed, 23 May 2018 15:54:54 +0200 Message-ID: References: <20180522165842.233949-1-groeck@google.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id D1560267265 for ; Wed, 23 May 2018 15:54:57 +0200 (CEST) In-Reply-To: <20180522165842.233949-1-groeck@google.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Guenter Roeck Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown , Chintan Patel , Guenter Roeck List-Id: alsa-devel@alsa-project.org On Tue, 22 May 2018 18:58:42 +0200, Guenter Roeck wrote: > > +struct skl_dfw_v4_module_caps { > + u32 set_params:2; > + u32 rsvd:30; > + u32 param_id; > + u32 caps_size; > + u32 caps[HDA_SST_CFG_MAX]; > +}; Missing __packed attribute? And I'm wondering whether we should move these definitions to uapi headers. thanks, Takashi