From: Takashi Iwai Subject: Re: [PATCH 2/5] ALSA: snd-usb: implement new endpoint streaming model Date: Tue, 20 Dec 2011 16:08:52 +0100 Message-ID: References: <1324374520-32332-1-git-send-email-zonque@gmail.com> <1324374520-32332-3-git-send-email-zonque@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id F2E60103B4F for ; Tue, 20 Dec 2011 16:08:52 +0100 (CET) In-Reply-To: <1324374520-32332-3-git-send-email-zonque@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Daniel Mack Cc: blablack@gmail.com, alsa-devel@alsa-project.org, clemens@ladisch.de, gdiffey@gmail.com, linuxaudio@showlabor.de List-Id: alsa-devel@alsa-project.org At Tue, 20 Dec 2011 10:48:37 +0100, Daniel Mack wrote: > > In order to split changes properly, this patch only adds the new > implementation but leaves the old one around, so the the driver doesn't > change its behaviour. The switch to actually use the new code is > submitted separately. > > Signed-off-by: Daniel Mack One point I'm not sure about this implementation is the use of tasklet. The tasklet itself runs again in ep->lock, what's the rationale for it? In other words, can't it be a straight function call? I would understand if it were a workqueue and running in the schedulable context. But, I see no big merit of tasklet here. (And tasklet is a candidate to be dropped sometime in future.) Maybe I'm missing something behind it... thanks, Takashi