From: Takashi Iwai Subject: Re: [PATCH] ALSA driver for SGI O2 audio board Date: Fri, 11 Jul 2008 09:56:17 +0200 Message-ID: References: <20080704234559.C959CFB63A@solo.franken.de> <20080709175059.GA10046@alpha.franken.de> <20080709183138.GA21872@alpha.franken.de> <20080710170011.GA8659@alpha.franken.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (ns.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id ED50D1037FB for ; Thu, 10 Jul 2008 21:56:23 +0200 (CEST) In-Reply-To: <20080710170011.GA8659@alpha.franken.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Thomas Bogendoerfer Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Thu, 10 Jul 2008 19:00:11 +0200, Thomas Bogendoerfer wrote: > > On Thu, Jul 10, 2008 at 05:52:50PM +0200, Takashi Iwai wrote: > > At Wed, 9 Jul 2008 20:31:38 +0200, > > Thomas Bogendoerfer wrote: > > > > > > On Thu, Jul 10, 2008 at 02:15:26AM +0200, Takashi Iwai wrote: > > > > At Wed, 9 Jul 2008 19:50:59 +0200, > > > > > > If there are shared interrupts, they could be called before the > > > > > > initialization below. So, safer to move after the init. > > > > > > > > > > they can't be shared and it's already done before any hardware init. > > > > > > > > Then any reason to pass IRQF_SHARED? > > > > > > of course not. I'll remove it. > > > > v2 still has it... > > I know, I've sent it earlier. Just wanted to give v2 a little time, > if something else pops up. If everything else is ok, I'll respin > a v3 with just the IRQF_SHARED removed. Ah, OK. thanks, Takashi