From: Takashi Iwai Subject: Re: [PATCH] AC97 bus interface for ad-hoc drivers Date: Fri, 29 Jul 2005 17:19:42 +0200 Message-ID: References: <1121775624.14604.14.camel@cearnarfon> <1122582399.5371.90.camel@localhost.localdomain> <1122636040.3117.28.camel@localhost.localdomain> <1122641516.3117.38.camel@localhost.localdomain> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <1122641516.3117.38.camel@localhost.localdomain> Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Liam Girdwood Cc: Nicolas Pitre , alsa-devel@lists.sourceforge.net, Bill Gatliff List-Id: alsa-devel@alsa-project.org At Fri, 29 Jul 2005 13:51:56 +0100, Liam Girdwood wrote: > > I've made the review changes and as requested I've pasted the RFC by > Nicolas below:- > > "I would like to know what people think of the following patch. It > allows for a codec on an AC97 bus to be shared with other drivers which > are completely unrelated to audio. It registers a new bus type, and > whenever a codec instance is created then a device for it is also > registered with the driver model using that bus type. This allows, for > example, to use the extra features of the UCB1400 like the touchscreen > interface and the additional GPIOs and ADCs available on that chip for > battery monitoring. I have a working UCB1400 touchscreen driver here > that simply registers with the driver model happily working alongside > with audio features using this." > > Changes over RFC:- > > o Now matches codec name within codec group. > o Added ac97_dev_release() to stop kernel complaining about no release > method for device. > o Added "config SND_AC97_BUS" to sound/pci/Kconfig and moved "config > SND_AC97_CODEC" out with the PCI=n statement. > o module is now called snd-ac97-bus > > Signed-off-by: Liam Girdwood > Signed-off-by: Nicolas Pitre Thanks. I applied it to CVS with some modifications. - the registration and unregistration to ac97_bus is done in dev_register and dev_unregister callbacks. This assures that card->dev is set. - 2.2/2.4 workaronds in alsa-driver tree. Please check whether it's OK (later, after cvs tree is sync'ed) Takashi ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf