From: Takashi Iwai Subject: Re: aoss patch [against cvs?] Date: Tue, 27 Jul 2004 18:05:55 +0200 Sender: alsa-devel-admin@lists.sourceforge.net Message-ID: References: <20040723164816.622682b5@mango.fruits.de> <20040727174522.6fb1bca0@mango.fruits.de> Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20040727174522.6fb1bca0@mango.fruits.de> Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Florian Schmidt Cc: alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Tue, 27 Jul 2004 17:45:22 +0200, Florian Schmidt wrote: > > On Tue, 27 Jul 2004 15:51:49 +0200 > Takashi Iwai wrote: > > > At Fri, 23 Jul 2004 16:48:16 +0200, > > Florian Schmidt wrote: > > > > > > Hi > > > > > > here's a patch that builds upon my last one.. this cleans minor > > > things up a little bit and changes the manpage.. So this is not > > > against 1.0.5, but against 1.0.5 with my other patch applied.. > > > > Don't we need to check /dev/dsp[0-9] and /dev/mixer[0-9]? > > static int is_dsp_device(const char *pathname) > { > if(!pathname) return 0; > if(strncmp(pathname,"/dev/dsp",8) == 0) return 1; > if(strncmp(pathname,"/dev/adsp",9) == 0) return 1; > if(strncmp(pathname,"/dev/audio",10) == 0) return 1; > if(strncmp(pathname,"/dev/sound/dsp",14) == 0) return 1; > if(strncmp(pathname,"/dev/sound/adsp",15) == 0) return 1; > if(strncmp(pathname,"/dev/sound/audio",16) == 0) return 1; > return 0; > } > > this should return 1 for /dev/dsp*, dev/adsp*, /dev/audio*, > /dev/sound/dsp*, dev/sound/adsp*, /dev/sound/audio*, > > and this > > static int is_mixer_device(const char *pathname) > { > if(!pathname) return 0; > if(strncmp(pathname,"/dev/mixer",10) == 0) return 1; > if(strncmp(pathname,"/dev/sound/mixer",16) == 0) return 1; > return 0; > } > > should as well check /dev/mixer* and /dev/sound/*. Ok, point taken. Your patch was applied to cvs now. thanks, Takashi ------------------------------------------------------- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get your free copy of BEA WebLogic Workshop 8.1 today. http://ads.osdn.com/?ad_id=4721&alloc_id=10040&op=click