Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48753C433E2 for ; Tue, 21 Jul 2020 07:58:35 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD01C208E4 for ; Tue, 21 Jul 2020 07:58:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="cPI0O78F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD01C208E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 558D91667; Tue, 21 Jul 2020 09:57:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 558D91667 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1595318313; bh=tIJlb8C1WWIy/Iq3uDDVOdTxomDEJrwaJEUSQR9fBtA=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=cPI0O78FpxsW/nr/pAdh04NCJOPOJn/4+YmTVDEGHout0UUQhZsR7nstrOcYWlNc8 sV5eByYSXRg0P0pfDqqOO/i4rcN0IF8Rgg8H9TKB7nd6s1+GlGPgIxvOYZE0DsUeJR FuqDGw6OSPYCdR1mzntopQXUj1HKNojwYqdPcf8A= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D2B25F80212; Tue, 21 Jul 2020 09:57:42 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5B8FDF8024A; Tue, 21 Jul 2020 09:57:41 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id F395AF80087 for ; Tue, 21 Jul 2020 09:57:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz F395AF80087 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DDA52AFCD; Tue, 21 Jul 2020 07:57:40 +0000 (UTC) Date: Tue, 21 Jul 2020 09:57:34 +0200 Message-ID: From: Takashi Iwai To: =?UTF-8?B?UmVuw6k=?= Herman Subject: Re: [PATCH 3/3] snd-usb-6fire: Unmark struct snd_pcm_hardware const In-Reply-To: <20200721064853.9516-4-rene.herman@gmail.com> References: <20200721064853.9516-1-rene.herman@gmail.com> <20200721064853.9516-4-rene.herman@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: alsa-devel@alsa-project.org, Torsten Schenk X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 21 Jul 2020 08:48:53 +0200, René Herman wrote: > > struct snd_pcm_hardware pcm_hw is in fact changed in usb6fire_pcm_open() This must be superfluous. usb6fire_pcm_open() changes the field of the copied pcm_hw, not the original pcm_hw itself. Otherwise we must have got already a compile warning / error. thanks, Takashi > > Signed-off-by: René Herman > --- > pcm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pcm.c b/pcm.c > index cce1312..8ccf638 100644 > --- a/pcm.c > +++ b/pcm.c > @@ -40,7 +40,7 @@ enum { /* pcm streaming states */ > STREAM_STOPPING > }; > > -static const struct snd_pcm_hardware pcm_hw = { > +static struct snd_pcm_hardware pcm_hw = { > .info = SNDRV_PCM_INFO_MMAP | > SNDRV_PCM_INFO_INTERLEAVED | > SNDRV_PCM_INFO_BLOCK_TRANSFER | > -- > 2.17.1 >