From: Takashi Iwai Subject: Re: [PATCH v2] ALSA: hda/realtek: Add quirks for several Clevo notebook barebones Date: Thu, 27 Jun 2019 08:40:00 +0200 Message-ID: References: <20190619113311.31656-1-rs@tuxedocomputers.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9E491F896F0 for ; Thu, 27 Jun 2019 08:40:01 +0200 (CEST) In-Reply-To: <20190619113311.31656-1-rs@tuxedocomputers.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Richard Sailer Cc: alsa-devel@alsa-project.org, jeremy@system76.com List-Id: alsa-devel@alsa-project.org On Wed, 19 Jun 2019 13:33:11 +0200, Richard Sailer wrote: > > This adds 4 SND_PCI_QUIRK(...) lines for several barebone models of the ODM > Clevo. The model names are written in regex syntax to describe/match all clevo > models that are similar enough and use the same PCI SSID that this fixup works > for them. > > Additionally the lines regarding SSID 0x96e1 and 0x97e1 didn't fix audio for the > all our Clevo notebooks using these SSIDs (models Clevo P960* and P970*) since > ALC1220_FIXP_CLEVO_PB51ED_PINS swapped pins that are not necesarry to be > swapped. This patch initiates ALC1220_FIXUP_CLEVO_P950 instead for these model > and fixes the audio. > > This is strange since the System76 Oryx Pro also seems to be a P960 and > P970 barebone, so the original fixup should also not have worked for > them. @Jeremy: What's your take on this? > > Signed-off-by: Richard Sailer FYI, I queued the patch now. Let me know if you find anything new. thanks, Takashi