From: Takashi Iwai Subject: Re: [PATCH] line6: add a check for snd_card_register Date: Tue, 01 Jan 2019 10:00:07 +0100 Message-ID: References: <20181226033933.73306-1-kjlu@umn.edu> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20181226033933.73306-1-kjlu@umn.edu> Sender: linux-kernel-owner@vger.kernel.org To: Kangjie Lu Cc: alsa-devel@alsa-project.org, Jaroslav Kysela , pakki001@umn.edu, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Wed, 26 Dec 2018 04:39:31 +0100, Kangjie Lu wrote: > > The fix checks if snd_card_register() fails, and if so, issues a > warning. > > Signed-off-by: Kangjie Lu Hmm, you submitted multiple patches doing the similar things but the error messages are handled completely differently in both cases. Please make them consistent. ... and above all: > - snd_card_register(line6->card); > + if (snd_card_register(line6->card)) > + pr_warn("Failed to register ALSA card.\n"); This error message is almost useless. Better to use dev_*() variant. thanks, Takashi